mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gon Solo <gonsolo@gmail.com>
To: alexander.deucher@amd.com, christian.koenig@amd.com,
	airlied@linux.ie, daniel@ffwll.ch, Hawking.Zhang@amd.com,
	tao.zhou1@amd.com, Dennis.Li@amd.com, guchun.chen@amd.com,
	tom.stdenis@amd.com, amd-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	torvalds@linux-foundation.org
Subject: Unused lines
Date: Tue, 30 Jun 2020 08:03:01 +0200	[thread overview]
Message-ID: <20200630060301.GA108674@limone.gonsolo.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

Hi!

Are the 147MB or 1.6 million(!) lines in
drivers/gpu/drm/amd/include/asic_reg really necessary? I grepped a few
of them and they don't seem to be used, neither in the kernel nor drm or
mesa. As an example I removed one of the unused lines (see the attached
patch) and the amdgpu driver seems to build just fine.

Cheers,
g


[-- Attachment #2: 0001-Remove-unused-line.patch --]
[-- Type: text/x-diff, Size: 1070 bytes --]

From 6dbc3e4d129ce46f952c8365f6ca22b2e1aaa33b Mon Sep 17 00:00:00 2001
From: Gon Solo <gonsolo@gmail.com>
Date: Tue, 30 Jun 2020 07:47:12 +0200
Subject: [PATCH] Remove unused line.

---
 drivers/gpu/drm/amd/include/asic_reg/nbio/nbio_6_1_sh_mask.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/include/asic_reg/nbio/nbio_6_1_sh_mask.h b/drivers/gpu/drm/amd/include/asic_reg/nbio/nbio_6_1_sh_mask.h
index 29af5167cd00..d45bd18a05dd 100644
--- a/drivers/gpu/drm/amd/include/asic_reg/nbio/nbio_6_1_sh_mask.h
+++ b/drivers/gpu/drm/amd/include/asic_reg/nbio/nbio_6_1_sh_mask.h
@@ -24,7 +24,6 @@
 
 // addressBlock: nbio_pcie_pswuscfg0_cfgdecp
 //PSWUSCFG0_VENDOR_ID
-#define PSWUSCFG0_VENDOR_ID__VENDOR_ID__SHIFT                                                                 0x0
 #define PSWUSCFG0_VENDOR_ID__VENDOR_ID_MASK                                                                   0xFFFFL
 //PSWUSCFG0_DEVICE_ID
 #define PSWUSCFG0_DEVICE_ID__DEVICE_ID__SHIFT                                                                 0x0
-- 
2.25.1


                 reply	other threads:[~2020-06-30  6:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200630060301.GA108674@limone.gonsolo.de \
    --to=gonsolo@gmail.com \
    --cc=Dennis.Li@amd.com \
    --cc=Hawking.Zhang@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=guchun.chen@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tao.zhou1@amd.com \
    --cc=tom.stdenis@amd.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®