From: Peter Zijlstra <peterz@infradead.org>
To: Chen Ni <vulab@iscas.ac.cn>
Cc: mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel: events: use offset_in_page macro
Date: Tue, 30 Jun 2020 09:50:26 +0200 [thread overview]
Message-ID: <20200630075026.GN4817@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200630074258.8301-1-vulab@iscas.ac.cn>
On Tue, Jun 30, 2020 at 07:42:58AM +0000, Chen Ni wrote:
> Use offset_in_page macro instead of (addr & ~PAGE_MASK).
Shees, so now we're replacing a trivial expression with something that's
actually longer to type? How does that make sense?
> - memcpy(dst, kaddr + (vaddr & ~PAGE_MASK), len);
> + memcpy(dst, kaddr + offset_in_page(vaddr), len);
next prev parent reply other threads:[~2020-06-30 7:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 7:42 Chen Ni
2020-06-30 7:50 ` Peter Zijlstra [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-13 2:28 Xu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630075026.GN4817@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®