From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 617C0C433DF for ; Tue, 30 Jun 2020 13:33:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 38E8C206C0 for ; Tue, 30 Jun 2020 13:33:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ktsLrCTc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388155AbgF3Ndw (ORCPT ); Tue, 30 Jun 2020 09:33:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732724AbgF3NdK (ORCPT ); Tue, 30 Jun 2020 09:33:10 -0400 Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85FCDC061755 for ; Tue, 30 Jun 2020 06:33:10 -0700 (PDT) Received: by mail-io1-xd44.google.com with SMTP id m81so21005074ioa.1 for ; Tue, 30 Jun 2020 06:33:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=riisFCPpfIy+ddIeKemrrsU0BmBozz0Ml8rD1KyP5/o=; b=ktsLrCTc/Su3iZGXae226c0RZ8TahBwtS3/Dt7AIozO9WfjMBKih7FkhSYt1fxrd0/ yR6k0TlCcG5GCV80FF+WW7HVUzzltC1l7tW5M8j+XiE9zZOjeetKjDQa4EQ8mGkSkaiO RwmSvFCuXcrHLyTP+P6HiPUcdP+6hAILeqgXSYW5xbEKwr/rHsr8hNgCaF+DTVIbxPH+ gRDyLDtdmzzgX5tOfgdjiZRxrBHcZZmZ4mI1Sq3MMPfUW6OSWYlh8NA95WyOVCUI9eqX 7kWqrGc3XXVxxfsjnE1V58KffQMqI/taU7buHFFkVyuz+VGs0lxFJeeVQdj9pr0v7u5f F2ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=riisFCPpfIy+ddIeKemrrsU0BmBozz0Ml8rD1KyP5/o=; b=QcaR3G5Bda8HIy9msOuGiY86yP0hoKcbFM8BUizMklTIeh8sEhZWw3mdAOjEZGCnxx w0rWNBiozqU2O4bdzOxwuCjJXdWei8ryvKhEpjfrWkBRB49E20k9N+fGaxiO4pbsJ90G mrQbquSDBt9qJ1PTxflMvglnB6M/8d1A6ms9OR/A5FN7cylUME7c8iR6oQFUeJb8KmgN sI6ttMHW3DG2UU+z6Aw5Ptrw1m01f9iHTRLEEpS0aTjXcXEC2+l75QwiuVuaklB1KgO5 MMWeZRA4GZOyP5nxBVwySiY9ab3ggg4CFTYEJWioCwdSZTC9Mo+tgX5V4k8dNu7xNQpI 7q4g== X-Gm-Message-State: AOAM533rDTyL5TXKVliz5bSEc6iGiKxu5o4YwxRNcssx7ITWl58CoWQD M8a1i0movwBpeB40z/GRDvGfWA== X-Google-Smtp-Source: ABdhPJyxkdvw3QKz0HMO2AiqGyCAIpBnZDMY5qytsopl8ajmuCMHUpnwfXppdlrX47I2lC/rIJPUmA== X-Received: by 2002:a6b:8e56:: with SMTP id q83mr21855491iod.61.1593523989803; Tue, 30 Jun 2020 06:33:09 -0700 (PDT) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id u15sm1538776iog.18.2020.06.30.06.33.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:09 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: evgreen@chromium.org, subashab@codeaurora.org, cpratapa@codeaurora.org, bjorn.andersson@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 2/5] net: ipa: metadata_mask register is RX only Date: Tue, 30 Jun 2020 08:33:01 -0500 Message-Id: <20200630133304.1331058-3-elder@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133304.1331058-1-elder@linaro.org> References: <20200630133304.1331058-1-elder@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The INIT_HDR_METADATA_MASK endpoint configuration register is only valid for RX endpoints. Rather than writing a zero to that register for TX endpoints, avoid writing the register at all. Signed-off-by: Alex Elder --- v2: The commented call to assert() that was added is now gone. drivers/net/ipa/ipa_endpoint.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c index 31afe282f347..1babcfc79360 100644 --- a/drivers/net/ipa/ipa_endpoint.c +++ b/drivers/net/ipa/ipa_endpoint.c @@ -530,7 +530,7 @@ static void ipa_endpoint_init_hdr_metadata_mask(struct ipa_endpoint *endpoint) offset = IPA_REG_ENDP_INIT_HDR_METADATA_MASK_N_OFFSET(endpoint_id); /* Note that HDR_ENDIANNESS indicates big endian header fields */ - if (!endpoint->toward_ipa && endpoint->data->qmap) + if (endpoint->data->qmap) val = cpu_to_be32(IPA_ENDPOINT_QMAP_METADATA_MASK); iowrite32(val, endpoint->ipa->reg_virt + offset); @@ -1302,10 +1302,10 @@ static void ipa_endpoint_program(struct ipa_endpoint *endpoint) (void)ipa_endpoint_program_suspend(endpoint, false); ipa_endpoint_init_hdr_ext(endpoint); ipa_endpoint_init_aggr(endpoint); + ipa_endpoint_init_hdr_metadata_mask(endpoint); } ipa_endpoint_init_cfg(endpoint); ipa_endpoint_init_hdr(endpoint); - ipa_endpoint_init_hdr_metadata_mask(endpoint); ipa_endpoint_init_mode(endpoint); ipa_endpoint_status(endpoint); } -- 2.25.1