From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D1C5C433E2 for ; Tue, 30 Jun 2020 13:33:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1094320722 for ; Tue, 30 Jun 2020 13:33:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Og34JDlm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388058AbgF3Ndc (ORCPT ); Tue, 30 Jun 2020 09:33:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387561AbgF3NdO (ORCPT ); Tue, 30 Jun 2020 09:33:14 -0400 Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD628C03E97E for ; Tue, 30 Jun 2020 06:33:13 -0700 (PDT) Received: by mail-il1-x142.google.com with SMTP id x9so17734596ila.3 for ; Tue, 30 Jun 2020 06:33:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NLGLXbQMNnc8WjfyUZyG3CP5YRJLw4TctWKcG9p/1fY=; b=Og34JDlmtuj4ZWyd3kF6svBJGNitRgk6p5FKsa/nN75Ah9a3Es3O+eZM45muel+Rhk dleUbXgNYLtuEu1EZhtXgIohsx1jZkZShfZo42mG8DCqJhU0xFQzto/2o+ZbGDXBYHk1 AVqPGWNnIHeMOhdemIMtMrRAXGDaH4D8dUUd5TjvCS7pKPEAzsYqIU7pmeIY2sOJBMiP BgejmR7zkKReFMxWg7zwE03VaaPK2SW/Pl9iKISDjDuGn+lGXm4YjDOgjSR7FHVGVEo7 1b+HDCEPXjfzWLI+SyDHcekCsXTeFmOi6fKfP6gQfm6Yi2Z7JLZcbSBhGUR+xTlTiEZI Bkxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NLGLXbQMNnc8WjfyUZyG3CP5YRJLw4TctWKcG9p/1fY=; b=g9A7c2+a8K4oF/OoiShtNWY9LMXGK79dGco5cEWOJHewc0DV6jkpJVGxLvMPep9Ssv lkMFveyqCD5SJGv2vOAYPU7YhvMQMVU0R8UqlDMvRB2ZaaALBfO3s388+dGn2k27mh42 94k4VrEw586Hiu0VBEZL+szLOAnfrHOsc4Bc8xo7zIDav0eEaPwmD3+FT0znXxn8ty1I dmRIUMysQs1SFBWcyBzABjgjYUE/xdW3pJL4nRcy8nIGoeIUQjMq087FjU6J/H5/Luvi +eQzqC9HvDwIo3gYFRbFuRDd8mFxpLvbuLPDTfvYt44BAxAAm4FVogK7/klxGeDF4El1 I8Bw== X-Gm-Message-State: AOAM533mn4mAv7uml8kHa2zHAM2FDf7L4/u7YwfumhJE2OFEIdxNC2DC XjVxj940EmBbo5GO5PxnQJVwre09z5I= X-Google-Smtp-Source: ABdhPJw66g+pzD6SChh6fz8L9HaekvjhhDK3h3faS6u77tdaxPXovHmZ0aCeUuLIB3ugdqbs5445Gw== X-Received: by 2002:a92:9f0e:: with SMTP id u14mr2460094ili.277.1593523993143; Tue, 30 Jun 2020 06:33:13 -0700 (PDT) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id u15sm1538776iog.18.2020.06.30.06.33.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:12 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: evgreen@chromium.org, subashab@codeaurora.org, cpratapa@codeaurora.org, bjorn.andersson@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 5/5] net: ipa: HOL_BLOCK_EN_FMASK is a 1-bit mask Date: Tue, 30 Jun 2020 08:33:04 -0500 Message-Id: <20200630133304.1331058-6-elder@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133304.1331058-1-elder@linaro.org> References: <20200630133304.1331058-1-elder@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The convention throughout the IPA driver is to directly use single-bit field mask values, rather than using (for example) u32_encode_bits() to set or clear them. Fix the one place that doesn't follow that convention, which sets HOL_BLOCK_EN_FMASK in ipa_endpoint_init_hol_block_enable(). Signed-off-by: Alex Elder --- v2: No change from version 1. drivers/net/ipa/ipa_endpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c index 566ff6a09e65..0332dcbcaaae 100644 --- a/drivers/net/ipa/ipa_endpoint.c +++ b/drivers/net/ipa/ipa_endpoint.c @@ -671,7 +671,7 @@ ipa_endpoint_init_hol_block_enable(struct ipa_endpoint *endpoint, bool enable) u32 offset; u32 val; - val = u32_encode_bits(enable ? 1 : 0, HOL_BLOCK_EN_FMASK); + val = enable ? HOL_BLOCK_EN_FMASK : 0; offset = IPA_REG_ENDP_INIT_HOL_BLOCK_EN_N_OFFSET(endpoint_id); iowrite32(val, endpoint->ipa->reg_virt + offset); } -- 2.25.1