From: Viresh Kumar <viresh.kumar@linaro.org>
To: Xin Hao <xhao@linux.alibaba.com>
Cc: rjw@rjwysocki.net, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] cpufreq: CPPC: fix some unreasonable codes in cppc_cpufreq_perf_to_khz()
Date: Wed, 1 Jul 2020 09:42:44 +0530 [thread overview]
Message-ID: <20200701041244.bhes5bvtcfvm3zbb@vireshk-i7> (raw)
In-Reply-To: <20200701032610.11944-1-xhao@linux.alibaba.com>
On 01-07-20, 11:26, Xin Hao wrote:
> The 'caps' variable has been defined, so there is no need to get
> 'highest_perf' value through 'cpu->caps.highest_perf', you can use
> 'caps->highest_perf' instead.
>
> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
> ---
> drivers/cpufreq/cppc_cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index 257d726a4456..444ee76a6bae 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -161,7 +161,7 @@ static unsigned int cppc_cpufreq_perf_to_khz(struct cppc_cpudata *cpu,
> if (!max_khz)
> max_khz = cppc_get_dmi_max_khz();
> mul = max_khz;
> - div = cpu->perf_caps.highest_perf;
> + div = caps->highest_perf;
> }
> return (u64)perf * mul / div;
> }
Applied. Thanks.
--
viresh
prev parent reply other threads:[~2020-07-01 4:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 3:26 Xin Hao
2020-07-01 4:12 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701041244.bhes5bvtcfvm3zbb@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=xhao@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®