mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: arnd@arndb.de, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
	Michael Jung <mijung@gmx.net>,
	Michael Ruettger <michael@ibmra.de>,
	Frank Haverkamp <haver@linux.ibm.com>,
	Joerg-Stephan Vogt <jsvogt@de.ibm.com>
Subject: [PATCH v2 02/30] misc: genwqe: card_sysfs: Demote function/file headers from kerneldoc
Date: Wed,  1 Jul 2020 09:30:50 +0100	[thread overview]
Message-ID: <20200701083118.45744-3-lee.jones@linaro.org> (raw)
In-Reply-To: <20200701083118.45744-1-lee.jones@linaro.org>

There has been no attempt to provide documentation for these function's
arguments, so align with the remainder of the file and just treat
them as standards function headers.

Fixes the following W=1 kernel build warnings:

 drivers/misc/genwqe/card_sysfs.c:32: warning: cannot understand function prototype: 'const char * const genwqe_types[] = '
 drivers/misc/genwqe/card_sysfs.c:150: warning: Function parameter or member 'dev' not described in 'curr_bitstream_show'
 drivers/misc/genwqe/card_sysfs.c:150: warning: Function parameter or member 'attr' not described in 'curr_bitstream_show'
 drivers/misc/genwqe/card_sysfs.c:150: warning: Function parameter or member 'buf' not described in 'curr_bitstream_show'
 drivers/misc/genwqe/card_sysfs.c:166: warning: Function parameter or member 'dev' not described in 'next_bitstream_show'
 drivers/misc/genwqe/card_sysfs.c:166: warning: Function parameter or member 'attr' not described in 'next_bitstream_show'
 drivers/misc/genwqe/card_sysfs.c:166: warning: Function parameter or member 'buf' not described in 'next_bitstream_show'
 drivers/misc/genwqe/card_sysfs.c:271: warning: Function parameter or member 'kobj' not described in 'genwqe_is_visible'
 drivers/misc/genwqe/card_sysfs.c:271: warning: Function parameter or member 'attr' not described in 'genwqe_is_visible'
 drivers/misc/genwqe/card_sysfs.c:271: warning: Function parameter or member 'n' not described in 'genwqe_is_visible'

Cc: Michael Jung <mijung@gmx.net>
Cc: Michael Ruettger <michael@ibmra.de>
Cc: Frank Haverkamp <haver@linux.ibm.com>
Cc: Joerg-Stephan Vogt <jsvogt@de.ibm.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/misc/genwqe/card_sysfs.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/misc/genwqe/card_sysfs.c b/drivers/misc/genwqe/card_sysfs.c
index 28a3fb1533f70..b2f115602523a 100644
--- a/drivers/misc/genwqe/card_sysfs.c
+++ b/drivers/misc/genwqe/card_sysfs.c
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-only
-/**
+/*
  * IBM Accelerator Family 'GenWQE'
  *
  * (C) Copyright IBM Corp. 2013
@@ -129,7 +129,7 @@ static ssize_t base_clock_show(struct device *dev,
 }
 static DEVICE_ATTR_RO(base_clock);
 
-/**
+/*
  * curr_bitstream_show() - Show the current bitstream id
  *
  * There is a bug in some old versions of the CPLD which selects the
@@ -156,7 +156,7 @@ static ssize_t curr_bitstream_show(struct device *dev,
 }
 static DEVICE_ATTR_RO(curr_bitstream);
 
-/**
+/*
  * next_bitstream_show() - Show the next activated bitstream
  *
  * IO_SLC_CFGREG_SOFTRESET: This register can only be accessed by the PF.
@@ -260,7 +260,7 @@ static struct attribute *genwqe_normal_attributes[] = {
 	NULL,
 };
 
-/**
+/*
  * genwqe_is_visible() - Determine if sysfs attribute should be visible or not
  *
  * VFs have restricted mmio capabilities, so not all sysfs entries
-- 
2.25.1


  parent reply	other threads:[~2020-07-01  8:33 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01  8:30 [PATCH v2 00/30] Last batch of patches to clean up Misc Lee Jones
2020-07-01  8:30 ` [PATCH v2 01/30] misc: genwqe: card_ddcb: Fix a variety of kerneldoc issues Lee Jones
2020-07-01  8:30 ` Lee Jones [this message]
2020-07-01  8:30 ` [PATCH v2 03/30] misc: genwqe: card_debugfs: Demote file header from kerneldoc Lee Jones
2020-07-01  8:30 ` [PATCH v2 04/30] misc: sgi-xp: xp_main: Staticify local functions xp_init() and xp_exit() Lee Jones
2020-07-01  8:30 ` [PATCH v2 05/30] misc: ibmasm: event: Demote function headers from kerneldoc Lee Jones
2020-07-01  8:30 ` [PATCH v2 06/30] misc: ibmasm: command: " Lee Jones
2020-07-01  8:30 ` [PATCH v2 07/30] misc: vmw_vmci_defs: Mark 'struct vmci_handle VMCI_ANON_SRC_HANDLE' as __maybe_unused Lee Jones
2020-07-01 10:33   ` Lee Jones
2020-07-01  8:30 ` [PATCH v2 08/30] misc: ibmasm: r_heartbeat: Demote function headers from kerneldoc Lee Jones
2020-07-01  8:30 ` [PATCH v2 09/30] misc: mic: host: mic_x100: Move declaration of mic_x100_intr_init[] into c-file Lee Jones
2020-07-01  8:30 ` [PATCH v2 10/30] misc: ibmasm: dot_command: Demote function headers from kerneldoc Lee Jones
2020-07-01  8:30 ` [PATCH v2 11/30] misc: mic: host: mic_intr: Properly document function arguments Lee Jones
2020-07-01  8:31 ` [PATCH v2 12/30] misc: mic: host: mic_x100: Add missing descriptions to kerneldoc headers Lee Jones
2020-07-01  8:31 ` [PATCH v2 13/30] misc: mic: card: mic_debugfs: Demote function headers from kerneldoc Lee Jones
2020-07-01  8:31 ` [PATCH v2 14/30] misc: mic: host: " Lee Jones
2020-07-01  8:31 ` [PATCH v2 15/30] misc: mic: cosm: cosm_main: Document 'force' function argument Lee Jones
2020-07-01  8:31 ` [PATCH v2 16/30] misc: mic: scif: scif_ports: Fix copy 'n' paste error Lee Jones
2020-07-01  8:31 ` [PATCH v2 17/30] misc: mic: cosm: cosm_debugfs: Demote function headers from kerneldoc Lee Jones
2020-07-01  8:31 ` [PATCH v2 18/30] misc: mic: scif: scif_api: Remove set but unused variable 'read_size' Lee Jones
2020-07-01  8:31 ` [PATCH v2 19/30] misc: mic: scif: scif_api: Demote scif_accept() function header Lee Jones
2020-07-01  8:31 ` [PATCH v2 20/30] misc: mic: scif: scif_epd: Describe missing 'scifdev' argument(s) Lee Jones
2020-07-01  8:31 ` [PATCH v2 21/30] misc: mic: scif: scif_nodeqp: Fix a bunch of kerneldoc issues Lee Jones
2020-07-01  8:31 ` [PATCH v2 22/30] misc: mic: scif: scif_nm: Supply various kerneldoc fix-ups Lee Jones
2020-07-01  8:31 ` [PATCH v2 23/30] misc: mic: scif: scif_dma: Fix a couple of kerneldoc issues Lee Jones
2020-07-01  8:31 ` [PATCH v2 24/30] misc: mic: scif: scif_fence: Fix a bunch of different documentation issues Lee Jones
2020-07-01  8:31 ` [PATCH v2 25/30] misc: mic: scif: scif_rma: Repair a bunch of kerneldoc issues Lee Jones
2020-07-01  8:31 ` [PATCH v2 26/30] misc: eeprom: at24: Tell the compiler that ACPI functions may not be used Lee Jones
2020-07-01  8:48   ` Wolfram Sang
2020-07-01  9:36   ` Lee Jones
2020-07-06 17:16     ` Bartosz Golaszewski
2020-07-01  8:31 ` [PATCH v2 27/30] misc: cxl: hcalls: Demote half-assed kerneldoc attempt Lee Jones
2020-07-01  8:31 ` [PATCH v2 28/30] misc: ocxl: config: Provide correct formatting to function headers Lee Jones
2020-07-01  8:31 ` [PATCH v2 29/30] misc: ibmvmc: Repair ill-named function argument descriptions Lee Jones
2020-07-01  8:31 ` [PATCH v2 30/30] misc: cxl: flash: Remove unused pointer Lee Jones
2020-07-01 13:13   ` Greg KH
2020-07-01 13:31     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200701083118.45744-3-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=haver@linux.ibm.com \
    --cc=jsvogt@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@ibmra.de \
    --cc=mijung@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®