From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACA1CC433E0 for ; Wed, 1 Jul 2020 10:32:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87A7320747 for ; Wed, 1 Jul 2020 10:32:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=megous.com header.i=@megous.com header.b="LKl1+NVC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730110AbgGAKcK (ORCPT ); Wed, 1 Jul 2020 06:32:10 -0400 Received: from vps.xff.cz ([195.181.215.36]:42456 "EHLO vps.xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730004AbgGAKbm (ORCPT ); Wed, 1 Jul 2020 06:31:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1593599494; bh=3QXBBwf2NX/RkQpQ64nV5k6ulAezZ6ucTw8Gf1SveRQ=; h=From:To:Cc:Subject:Date:References:From; b=LKl1+NVC7OIRwW9kuhH1lYlhx/QATsVz6EqGOZ63DG8aeRkXN0rTIhc9f6UOPJitL LVlzEHNsG0HM6IQzDPjrY4TaTuXolUuCrVOQiXCcfz0LpUTXwPe6W5T0YSyIcX7tJm peIrF4ciQlz7dO1gjRFVXkIcP1QX6IkkPKaseu+M= From: Ondrej Jirman To: linux-sunxi@googlegroups.com, Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , =?UTF-8?q?Guido=20G=C3=BCnther?= , Purism Kernel Team , Rob Herring , Maxime Ripard , Chen-Yu Tsai , Linus Walleij , Icenowy Zheng Cc: Ondrej Jirman , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Samuel Holland , Martijn Braam , Luca Weiss , Bhushan Shah Subject: [PATCH v6 11/13] drm/panel: st7703: Assert reset prior to powering down the regulators Date: Wed, 1 Jul 2020 12:31:24 +0200 Message-Id: <20200701103126.1512615-12-megous@megous.com> In-Reply-To: <20200701103126.1512615-1-megous@megous.com> References: <20200701103126.1512615-1-megous@megous.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The reset pin is inverted, so if we don't assert reset, the actual gpio will be high and may keep driving the IO port of the panel. Signed-off-by: Ondrej Jirman Reviewed-by: Linus Walleij --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c index 0c4167994d01..e303b7b1a215 100644 --- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c +++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c @@ -417,6 +417,7 @@ static int st7703_unprepare(struct drm_panel *panel) if (!ctx->prepared) return 0; + gpiod_set_value_cansleep(ctx->reset_gpio, 1); regulator_disable(ctx->iovcc); regulator_disable(ctx->vcc); ctx->prepared = false; -- 2.27.0