Re: [for-next][PATCH 7/8] ktest.pl: Add the log of last test in email on failure

[Steven Rostedt <rostedt@goodmis.org>]

On Thu, 2 Jul 2020 09:42:35 +0200
Greg KH <gregkh@linuxfoundation.org> wrote:

> >      doprint "\n\n";
> > +
> > +    if (defined($opt{"LOG_FILE"})) {
> > +	$test_log_start = tell(LOG);
> > +    }  
> 
> Nit, the mix of spaces and tabs in this file is always annoying to me,
> but it's your code...
> 

It's the default way emacs does Perl code. I call it "oyster mode".

I like to keep it that way as it reminds me that this is Perl and not C. ;-)


> > +
> >      doprint "RUNNING TEST $i of $opt{NUM_TESTS}$name with option $test_type $run_type$installme\n\n";
> >  
> >      if (defined($pre_test)) {
> > @@ -4461,6 +4496,7 @@ if ($email_when_finished) {
> >  }
> >  
> >  if (defined($opt{"LOG_FILE"})) {
> > +
> >      print "\n See $opt{LOG_FILE} for the record of results.\n\n";
> >      close LOG;
> >  }  
> 
> Extra blank line?

Will nuke. (Left over from having a debug print in there).

> 
> Anyway, looks sane to me
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Awesome. Thanks for looking this over!

-- Steve