From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FFDAC433E0 for ; Thu, 2 Jul 2020 11:05:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E01552075D for ; Thu, 2 Jul 2020 11:05:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="N5oiHn9g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728376AbgGBLFz (ORCPT ); Thu, 2 Jul 2020 07:05:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728007AbgGBLFy (ORCPT ); Thu, 2 Jul 2020 07:05:54 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C833BC08C5C1 for ; Thu, 2 Jul 2020 04:05:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=W7vOkyxsbYhaQ0GGmRUCdYNP3bzUA8L6GrJCj+KCQMo=; b=N5oiHn9gfkXS1SWEc806/XUf6k vUSGLyKW9Cx/xBI2iSjUwMKmOD2jkbGkGhEe8YywPJfM716/TfAZbVZ7mo85ZJftrNve8sR+D9j5r WyckWcckppDAXPvlaU8PoECAK5z8f/rMEmz6dtoajx3dOirlVLoDzsFcAb1bi/ymuDZeVGgVk4b9r D18gi9NUXThq/kURC3l7QuQyDSGtkRjv/MX7DVNyNEo0ieo7VGS9pUZiwM9yD/rgDokSr25vBcGU2 LjXKOeTqcjQQesDwSw9o1Y+Cs2a4UgxIdArGi/3ZFmKh1oPKjv4/dw2NFrkKtgrk2LRgEKqqffplV bQT0/pAA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqx2F-0008PQ-Ic; Thu, 02 Jul 2020 11:05:44 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 970CB30015A; Thu, 2 Jul 2020 13:05:42 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 8409022172012; Thu, 2 Jul 2020 13:05:42 +0200 (CEST) Date: Thu, 2 Jul 2020 13:05:42 +0200 From: Peter Zijlstra To: Chen Wandun Cc: jpoimboe@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] objtool: fix potential memory leak special_get_alts() Message-ID: <20200702110542.GP4800@hirez.programming.kicks-ass.net> References: <20200702110025.16883-1-chenwandun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200702110025.16883-1-chenwandun@huawei.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 02, 2020 at 07:00:25PM +0800, Chen Wandun wrote: > If get_alt_entry() return error, struct special_alt will leak. > > Fixes: 442f04c34a1a ("objtool: Add tool to perform compile-time stack metadata validation") > Signed-off-by: Chen Wandun https://lkml.kernel.org/r/20200427144439.rrywv56mjfypupgh@treble