From: Alan Stern <stern@rowland.harvard.edu>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
mylene.josserand@collabora.com,
Suniel Mahesh <sunil@amarulasolutions.com>,
Michael Trimarchi <michael@amarulasolutions.com>,
linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-amarula <linux-amarula@amarulasolutions.com>,
William Wu <william.wu@rock-chips.com>
Subject: Re: [PATCH] usb: host: ohci-platform: Disable ohci for rk3288
Date: Thu, 2 Jul 2020 09:26:05 -0400 [thread overview]
Message-ID: <20200702132605.GA586616@rowland.harvard.edu> (raw)
In-Reply-To: <20200702090504.36670-1-jagan@amarulasolutions.com>
On Thu, Jul 02, 2020 at 02:35:04PM +0530, Jagan Teki wrote:
> rk3288 has usb host0 ohci controller but doesn't actually work
> on real hardware but it works with new revision chip rk3288w.
>
> So, disable ohci for rk3288.
>
> For rk3288w chips the compatible update code is handled by bootloader.
>
> Cc: William Wu <william.wu@rock-chips.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Note:
> - U-Boot patch for compatible update
> https://patchwork.ozlabs.org/project/uboot/patch/20200702084820.35942-1-jagan@amarulasolutions.com/
>
> drivers/usb/host/ohci-platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
> index 7addfc2cbadc..24655ed6a7e0 100644
> --- a/drivers/usb/host/ohci-platform.c
> +++ b/drivers/usb/host/ohci-platform.c
> @@ -96,7 +96,7 @@ static int ohci_platform_probe(struct platform_device *dev)
> struct ohci_hcd *ohci;
> int err, irq, clk = 0;
>
> - if (usb_disabled())
> + if (usb_disabled() || of_machine_is_compatible("rockchip,rk3288"))
> return -ENODEV;
>
> /*
> --
> 2.25.1
Acked-by: Alan Stern <stern@rowland.harvard.edu>
next prev parent reply other threads:[~2020-07-02 13:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 9:05 Jagan Teki
2020-07-02 13:26 ` Alan Stern [this message]
2020-07-02 14:38 ` Robin Murphy
2020-07-03 11:39 ` Jagan Teki
2020-07-03 17:08 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702132605.GA586616@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=jagan@amarulasolutions.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=mylene.josserand@collabora.com \
--cc=robh+dt@kernel.org \
--cc=sunil@amarulasolutions.com \
--cc=william.wu@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®