From: kernel test robot <lkp@intel.com>
To: Vaibhav Gupta <vaibhavgupta40@gmail.com>,
Bjorn Helgaas <helgaas@kernel.org>,
bjorn@helgaas.com, Vaibhav Gupta <vaibhav.varodek@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Steve Glendinning <steve.glendinning@shawell.net>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH v1 2/2] smsc9420: use generic power management
Date: Fri, 3 Jul 2020 04:08:01 +0800 [thread overview]
Message-ID: <202007030309.DqqVrhAQ%lkp@intel.com> (raw)
In-Reply-To: <20200702105351.363880-3-vaibhavgupta40@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 4131 bytes --]
Hi Vaibhav,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.8-rc3 next-20200702]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Vaibhav-Gupta/smsc-use-generic-power-management/20200702-185914
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git cd77006e01b3198c75fb7819b3d0ff89709539bb
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 003a086ffc0d1affbb8300b36225fb8150a2d40a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/smsc/smsc9420.c:1466:6: warning: variable 'err' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (netif_running(dev)) {
^~~~~~~~~~~~~~~~~~
drivers/net/ethernet/smsc/smsc9420.c:1471:9: note: uninitialized use occurs here
return err;
^~~
drivers/net/ethernet/smsc/smsc9420.c:1466:2: note: remove the 'if' if its condition is always true
if (netif_running(dev)) {
^~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/smsc/smsc9420.c:1460:9: note: initialize the variable 'err' to silence this warning
int err;
^
= 0
1 warning generated.
vim +1466 drivers/net/ethernet/smsc/smsc9420.c
2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1456
7d465053ec82e2 drivers/net/ethernet/smsc/smsc9420.c Vaibhav Gupta 2020-07-02 1457 static int __maybe_unused smsc9420_resume(struct device *dev_d)
2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1458 {
7d465053ec82e2 drivers/net/ethernet/smsc/smsc9420.c Vaibhav Gupta 2020-07-02 1459 struct net_device *dev = dev_get_drvdata(dev_d);
2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1460 int err;
2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1461
7d465053ec82e2 drivers/net/ethernet/smsc/smsc9420.c Vaibhav Gupta 2020-07-02 1462 pci_set_master(to_pci_dev(dev_d));
2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1463
7d465053ec82e2 drivers/net/ethernet/smsc/smsc9420.c Vaibhav Gupta 2020-07-02 1464 device_wakeup_disable(dev_d);
2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1465
2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 @1466 if (netif_running(dev)) {
b5a80837b7e125 drivers/net/ethernet/smsc/smsc9420.c Francois Romieu 2012-03-09 1467 /* FIXME: gross. It looks like ancient PM relic.*/
2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1468 err = smsc9420_open(dev);
2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1469 netif_device_attach(dev);
2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1470 }
2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1471 return err;
2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1472 }
2cb377283f3469 drivers/net/smsc9420.c Steve Glendinning 2008-12-11 1473
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 75347 bytes --]
next prev parent reply other threads:[~2020-07-02 20:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 10:53 [PATCH v1 0/2] smsc: " Vaibhav Gupta
2020-07-02 10:53 ` [PATCH v1 1/2] epic100: " Vaibhav Gupta
2020-07-02 10:53 ` [PATCH v1 2/2] smsc9420: " Vaibhav Gupta
2020-07-02 20:08 ` kernel test robot [this message]
2020-07-03 3:03 ` Vaibhav Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202007030309.DqqVrhAQ%lkp@intel.com \
--to=lkp@intel.com \
--cc=bjorn@helgaas.com \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=helgaas@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=steve.glendinning@shawell.net \
--cc=vaibhav.varodek@gmail.com \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®