From: Petr Mladek <pmladek@suse.com>
To: qiang.zhang@windriver.com
Cc: ben.dooks@codethink.co.uk, bfields@redhat.com, cl@rock-chips.com,
peterz@infradead.org, tj@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kthread: Don't cancel a work that is being cancelled
Date: Fri, 3 Jul 2020 09:28:18 +0200 [thread overview]
Message-ID: <20200703072818.GC11587@alley> (raw)
In-Reply-To: <20200702044324.32927-1-qiang.zhang@windriver.com>
On Thu 2020-07-02 12:43:24, qiang.zhang@windriver.com wrote:
> From: Zhang Qiang <qiang.zhang@windriver.com>
>
> When canceling a work, if it is found that the work is in
> the cancelling state, we should directly exit the cancelled
> operation.
No, the function guarantees that the work is not longer running
when it returns. This is why it has the suffix "_sync" in the name.
We would need to add kthread_cancel_work() without the "_sync"
wrappers that would not wait for the work in progress. But it
might be dangerous. The API users usually want to make sure
that the work in not longer running to avoid races.
What is the use case for the non-sync behavior, please?
Best Regards,
Petr
next prev parent reply other threads:[~2020-07-03 7:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 4:43 qiang.zhang
2020-07-03 7:28 ` Petr Mladek [this message]
2020-07-03 8:57 ` 回复: " Zhang, Qiang
-- strict thread matches above, loose matches on Subject: below --
2020-07-02 1:13 qiang.zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200703072818.GC11587@alley \
--to=pmladek@suse.com \
--cc=ben.dooks@codethink.co.uk \
--cc=bfields@redhat.com \
--cc=cl@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=qiang.zhang@windriver.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®