From: Amit Shah <amitshah@gmx.net>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] virtio_console: Constify some static variables
Date: Sun, 5 Jul 2020 20:30:38 +0200 [thread overview]
Message-ID: <20200703175529.GE3150@trundl.on> (raw)
In-Reply-To: <20200701200950.30314-6-rikard.falkeborn@gmail.com>
On (Wed) 01 Jul 2020 [22:09:50], Rikard Falkeborn wrote:
> The id_table and feature_table pointers in struct virtio_driver are
> pointers to const. Mark the corresponding static variables const to
> allow the compiler to put them in read-only memory.
>
> Before:
> text data bss dec hex filename
> 25447 713 76 26236 667c drivers/char/virtio_console.o
>
> After:
> text data bss dec hex filename
> 25488 673 76 26237 667d drivers/char/virtio_console.o
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Reviewed-by: Amit Shah <amit@kernel.org>
Please CC me on the entire series instead of individual patches in the
future.
Thanks,
Amit
--
http://amitshah.net/
next prev parent reply other threads:[~2020-07-05 18:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 20:09 [PATCH 0/5] drivers/char: Constify " Rikard Falkeborn
2020-07-01 20:09 ` [PATCH 1/5] hwrng: bcm2835 - Constify bcm2835_rng_devtype[] Rikard Falkeborn
2020-07-01 21:52 ` Florian Fainelli
2020-07-01 20:09 ` [PATCH 2/5] hwrng: nomadik - Constify nmk_rng_ids[] Rikard Falkeborn
2020-07-02 7:51 ` Arnd Bergmann
2020-07-01 20:09 ` [PATCH 3/5] hwrng: virtio - Constify id_table[] Rikard Falkeborn
2020-07-01 20:09 ` [PATCH 4/5] ipmi: watchdog: Constify ident Rikard Falkeborn
2020-07-01 20:09 ` [PATCH 5/5] virtio_console: Constify some static variables Rikard Falkeborn
2020-07-05 18:30 ` Amit Shah [this message]
2020-07-05 20:50 ` Joe Perches
2020-07-02 8:58 ` [PATCH 0/5] drivers/char: Constify " Arnd Bergmann
2020-07-09 12:54 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200703175529.GE3150@trundl.on \
--to=amitshah@gmx.net \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rikard.falkeborn@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®