From: David Miller <davem@davemloft.net>
To: xie.he.0141@gmail.com
Cc: kuba@kernel.org, madhuparnabhowmik04@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-x25@vger.kernel.org
Subject: Re: [PATCH] drivers/net/wan/lapbether: Fixed the value of hard_header_len
Date: Sat, 04 Jul 2020 17:52:46 -0700 (PDT) [thread overview]
Message-ID: <20200704.175246.123858644791564054.davem@davemloft.net> (raw)
In-Reply-To: <20200704051246.203413-1-xie.he.0141@gmail.com>
From: Xie He <xie.he.0141@gmail.com>
Date: Fri, 3 Jul 2020 22:12:46 -0700
> When transmitting data from upper layers or from AF_PACKET sockets,
> this driver will first remove a pseudo header of 1 byte,
> then the lapb module will prepend the LAPB header of 2 or 3 bytes,
> then this driver will prepend a length field of 2 bytes,
> then the underlying Ethernet device will prepend its own header.
Please add something like this above text to a comment:
> @@ -324,6 +323,8 @@ static int lapbeth_new_device(struct net_device *dev)
> if (!ndev)
> goto out;
>
> + ndev->hard_header_len = -1 + 3 + 2 + dev->hard_header_len;
> +
Above this new line so that someone reading the code can understand
these magic numbers and what they mean.
Thank you.
prev parent reply other threads:[~2020-07-05 0:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 5:12 Xie He
2020-07-05 0:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200704.175246.123858644791564054.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=madhuparnabhowmik04@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®