mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Kees Cook <keescook@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Dominik Czarnota <dominik.czarnota@trailofbits.com>,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] Documentation: Clarify f_cred vs current_cred() use
Date: Sun, 5 Jul 2020 14:05:02 -0600	[thread overview]
Message-ID: <20200705140502.07bfc8bc@lwn.net> (raw)
In-Reply-To: <202007031038.8833A35DE4@keescook>

On Fri, 3 Jul 2020 10:44:22 -0700
Kees Cook <keescook@chromium.org> wrote:

> When making access control choices from a file-based context, f_cred
> must be used instead of current_cred() to avoid confused deputy attacks
> where an open file may get passed to a more privileged process. Add a
> short paragraph to explicitly state the rationale.
> 
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> I forgot to include this patch in my kallsyms_show_value() f_cred series:
> https://lore.kernel.org/lkml/20200702232638.2946421-1-keescook@chromium.org/
> I can either take this in that series, or it can go via docs?
> ---
>  Documentation/security/credentials.rst | 4 ++++
>  1 file changed, 4 insertions(+)

I've applied it, thanks.

jon

      reply	other threads:[~2020-07-05 20:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-03 17:44 Kees Cook
2020-07-05 20:05 ` Jonathan Corbet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200705140502.07bfc8bc@lwn.net \
    --to=corbet@lwn.net \
    --cc=dominik.czarnota@trailofbits.com \
    --cc=keescook@chromium.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®