mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: "Alexander A. Klimov" <grandmaster@al2klimov.de>
Cc: philipp.reisner@linbit.com, lars.ellenberg@linbit.com,
	axboe@kernel.dk, mchehab+samsung@kernel.org,
	drbd-dev@lists.linbit.com, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: DRBD driver
Date: Sun, 5 Jul 2020 14:22:00 -0600	[thread overview]
Message-ID: <20200705142200.2154779f@lwn.net> (raw)
In-Reply-To: <20200627103111.71771-1-grandmaster@al2klimov.de>

On Sat, 27 Jun 2020 12:31:11 +0200
"Alexander A. Klimov" <grandmaster@al2klimov.de> wrote:

> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
> 
> Deterministic algorithm:
> For each file:
>   If not .svg:
>     For each line:
>       If doesn't contain `\bxmlns\b`:
>         For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
>           If both the HTTP and HTTPS versions
>           return 200 OK and serve the same content:
>             Replace HTTP with HTTPS.
> 
> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>

So I've applied this but...
> ---
>  If there are any URLs to be removed completely or at least not HTTPSified:
>  Just clearly say so and I'll *undo my change*.
>  See also https://lkml.org/lkml/2020/6/27/64
> 
>  If there are any valid, but yet not changed URLs:
>  See https://lkml.org/lkml/2020/6/26/837
> 
>  Documentation/admin-guide/blockdev/drbd/index.rst | 2 +-
>  Documentation/admin-guide/blockdev/floppy.rst     | 6 +++---
>  drivers/block/drbd/Kconfig                        | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/admin-guide/blockdev/drbd/index.rst b/Documentation/admin-guide/blockdev/drbd/index.rst
> index 68ecd5c113e9..561fd1e35917 100644
> --- a/Documentation/admin-guide/blockdev/drbd/index.rst
> +++ b/Documentation/admin-guide/blockdev/drbd/index.rst
> @@ -10,7 +10,7 @@ Description
>    clusters and in this context, is a "drop-in" replacement for shared
>    storage. Simplistically, you could see it as a network RAID 1.
>  
> -  Please visit http://www.drbd.org to find out more.
> +  Please visit https://www.drbd.org to find out more.

This link redirects to a somewhat commercial page and may not be what was
intended back then.

>  
>  .. toctree::
>     :maxdepth: 1
> diff --git a/Documentation/admin-guide/blockdev/floppy.rst b/Documentation/admin-guide/blockdev/floppy.rst
> index 4a8f31cf4139..0328438ebe2c 100644
> --- a/Documentation/admin-guide/blockdev/floppy.rst
> +++ b/Documentation/admin-guide/blockdev/floppy.rst
> @@ -6,7 +6,7 @@ FAQ list:
>  =========
>  
>  A FAQ list may be found in the fdutils package (see below), and also
> -at <http://fdutils.linux.lu/faq.html>.
> +at <https://fdutils.linux.lu/faq.html>.

This page hasn't been updated in 15 years, and may be of limited utility.
The document itself talks about LILO on a 2.6.9 kernel, PS/2 floppies, and
other such bleeding-edge things.  It sure needs more help than this.

>  
>  
>  LILO configuration options (Thinkpad users, read this)
> @@ -220,11 +220,11 @@ It also contains additional documentation about the floppy driver.
>  
>  The latest version can be found at fdutils homepage:
>  
> - http://fdutils.linux.lu
> + https://fdutils.linux.lu
>  
>  The fdutils releases can be found at:
>  
> - http://fdutils.linux.lu/download.html
> + https://fdutils.linux.lu/download.html
>  
>   http://www.tux.org/pub/knaff/fdutils/

That link is completely dead and should just come out.

But at least we have some HTTPS links.  

jon

      reply	other threads:[~2020-07-05 20:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-27 10:31 Alexander A. Klimov
2020-07-05 20:22 ` Jonathan Corbet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200705142200.2154779f@lwn.net \
    --to=corbet@lwn.net \
    --cc=axboe@kernel.dk \
    --cc=drbd-dev@lists.linbit.com \
    --cc=grandmaster@al2klimov.de \
    --cc=lars.ellenberg@linbit.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+samsung@kernel.org \
    --cc=philipp.reisner@linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®