From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3861C433E1 for ; Mon, 6 Jul 2020 11:57:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8EA5F20771 for ; Mon, 6 Jul 2020 11:57:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="bz/0b6OJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729129AbgGFL5h (ORCPT ); Mon, 6 Jul 2020 07:57:37 -0400 Received: from smtp-fw-6001.amazon.com ([52.95.48.154]:21741 "EHLO smtp-fw-6001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728973AbgGFL5g (ORCPT ); Mon, 6 Jul 2020 07:57:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1594036656; x=1625572656; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=+B/TaSdGXlFhHgRvPYOAtllLokP1vfc1/RLWc3nWAVk=; b=bz/0b6OJ/709uxZw+WJtD/iq94Ix6S4WLhkf9Begy3YF9XU+IEPsW/d2 4TxhVFY1kkAeu4jdR2PfncQGl2BwawQqn1gVLJHaQ5Jp9Kt7PNTKp63dV NZF1EWCBWK2hOc8ewu74C8trVQFfvQP8iSoWYzCpyBhNZj00uJLyyDnQ0 Y=; IronPort-SDR: 9fuYkuzU1BTvILwnILLA7T2QEVAI9t72gC9nZhRr/6cg8lt1GJes0V16DWMhYN1eZobd+D2T0R /AAdoTIPEcsw== X-IronPort-AV: E=Sophos;i="5.75,318,1589241600"; d="scan'208";a="41657368" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-2a-69849ee2.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-out-6001.iad6.amazon.com with ESMTP; 06 Jul 2020 11:57:32 +0000 Received: from EX13MTAUEA002.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan2.pdx.amazon.com [10.170.41.162]) by email-inbound-relay-2a-69849ee2.us-west-2.amazon.com (Postfix) with ESMTPS id 8809BA21FB; Mon, 6 Jul 2020 11:57:29 +0000 (UTC) Received: from EX13D31EUA004.ant.amazon.com (10.43.165.161) by EX13MTAUEA002.ant.amazon.com (10.43.61.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 6 Jul 2020 11:57:29 +0000 Received: from u886c93fd17d25d.ant.amazon.com (10.43.160.100) by EX13D31EUA004.ant.amazon.com (10.43.165.161) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 6 Jul 2020 11:57:11 +0000 From: SeongJae Park To: CC: SeongJae Park , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v17 11/15] tools/damon/wss: Implement '--thres' option Date: Mon, 6 Jul 2020 13:53:18 +0200 Message-ID: <20200706115322.29598-12-sjpark@amazon.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200706115322.29598-1-sjpark@amazon.com> References: <20200706115322.29598-1-sjpark@amazon.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.43.160.100] X-ClientProxiedBy: EX13D21UWA003.ant.amazon.com (10.43.160.184) To EX13D31EUA004.ant.amazon.com (10.43.165.161) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: SeongJae Park Currently, 'wss' treats every region as working set if accessed at least once. Someone who want to know performance important working set only would want to ignore regions having low access frequency. '--thres' option can be used to set the minimal access frequency of the regions to be classified as the workingset. Using this, users can plot the reuse histogram. For example: $ damo record $(pidof raytrace) $ for t in {1..20}; do ./tools/damon/damo report wss --thres $t | \ grep avr | awk -v reuse_time=$(( (21 - t) * 5 )) \ '{print reuse_time " " $3}'; done 100 12838416 95 2222623 90 1585480 85 422890 80 67040 75 45218 70 13242 65 12896 60 12136 55 10872 50 9648 45 8136 40 7052 35 6304 30 5736 25 5404 20 5305 15 5187 10 5069 5 4873 Above command shows the reuse histogram of parsec3.raytrace. Remind that the sampling interval and aggregation interval are 5ms and 100ms by default and this command used the default values. So, the above output means that about 12MB of memory region was reused within 100 ms while only about 2MB of memory region was reused within 95 ms, then about 1.5MB within 90ms, and so on, in average. Signed-off-by: SeongJae Park --- tools/damon/wss.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/damon/wss.py b/tools/damon/wss.py index b43065176cfd..d2a1b149e3ea 100644 --- a/tools/damon/wss.py +++ b/tools/damon/wss.py @@ -17,6 +17,8 @@ def set_argparser(parser): parser.add_argument('--range', '-r', type=int, nargs=3, metavar=('', '', ''), help='range of wss percentiles to print') + parser.add_argument('--thres', '-t', type=int, metavar='<# accesses>', + help='minimal number of accesses for treated as working set') parser.add_argument('--sortby', '-s', choices=['time', 'size'], help='the metric to be used for the sort of the working set sizes') parser.add_argument('--plot', '-p', type=str, metavar='', @@ -67,7 +69,7 @@ def main(args=None): wss = 0 for p in snapshot: # Ignore regions not accessed - if p[1] <= 0: + if p[1] < args.thres: continue wss += p[0] wss_dist.append(wss) -- 2.17.1