From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64148C433DF for ; Mon, 6 Jul 2020 14:25:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C410206A1 for ; Mon, 6 Jul 2020 14:25:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="GcJ7x0qU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729223AbgGFOZe (ORCPT ); Mon, 6 Jul 2020 10:25:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729148AbgGFOZd (ORCPT ); Mon, 6 Jul 2020 10:25:33 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEFFDC061755 for ; Mon, 6 Jul 2020 07:25:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NG8skPFp/6zeMTXh00D2QCsBd5f6GNP2Qc+MjOiF/Nk=; b=GcJ7x0qUP49MS68Wt0xzBCnm3Q kkYaz+Uqdld50ababJc4hlVc4gI+HmNDG/QqlJ++7vjEs8BsoYYuhabzK6EjIx1rEb2Hcm4r6tEux i1baH9IDYLIyx2BXWq4cpnz4tDe2dcSQKRnG6bPj1PWsDun4qCkfvm10iO4yN31ERQH37ZQbfxjdr nHNW9ST9pgm27N9RAvFgRvkQrgk7s1i4D3kCk+DMofJOuIE1unMobv8eHCa7Je2ZNCEtpNLLZK4bd stcSBNfr+kNs6LsdBHqQObQlgIrWRtFbt5QOAXPS8czMclBs6EOAT2WgPi4SLktGHO7CgD/IrrlVV ykVS6oyA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsS3X-0004W7-M2; Mon, 06 Jul 2020 14:25:15 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 6351D3006D0; Mon, 6 Jul 2020 16:25:12 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 53C1D213C65B0; Mon, 6 Jul 2020 16:25:12 +0200 (CEST) Date: Mon, 6 Jul 2020 16:25:12 +0200 From: Peter Zijlstra To: "Liang, Kan" Cc: mingo@redhat.com, acme@kernel.org, tglx@linutronix.de, bp@alien8.de, x86@kernel.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, dave.hansen@intel.com, yu-cheng.yu@intel.com, bigeasy@linutronix.de, gorcunov@gmail.com, hpa@zytor.com, alexey.budankov@linux.intel.com, eranian@google.com, ak@linux.intel.com, like.xu@linux.intel.com, yao.jin@linux.intel.com, wei.w.wang@intel.com Subject: Re: [PATCH V3 13/23] perf/x86/intel/lbr: Factor out intel_pmu_store_lbr Message-ID: <20200706142512.GF4800@hirez.programming.kicks-ass.net> References: <1593780569-62993-1-git-send-email-kan.liang@linux.intel.com> <1593780569-62993-14-git-send-email-kan.liang@linux.intel.com> <20200703195024.GI2483@worktop.programming.kicks-ass.net> <20200706102557.GA597537@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 06, 2020 at 09:32:22AM -0400, Liang, Kan wrote: > > > On 7/6/2020 6:25 AM, Peter Zijlstra wrote: > > On Fri, Jul 03, 2020 at 04:59:49PM -0400, Liang, Kan wrote: > > > On 7/3/2020 3:50 PM, Peter Zijlstra wrote: > > > > > > If I'm not mistaken, this correctly deals with LBR_FORMAT_INFO, so can't > > > > we also use the intel_pmu_arch_lbr_read() function for that case? > > > > > > But the intel_pmu_arch_lbr_read() doesn't have the optimization > > > (LBR_NO_INFO) for the LBR_FORMAT_INFO. > > > https://lkml.kernel.org/r/tip-b16a5b52eb90d92b597257778e51e1fdc6423e64@git.kernel.org > > > > > > To apply the optimization, we need extra codes as below. > > > > Right, I saw that, but shouldn't we support that for anything with this > > format anyway? That is, it's weird and inconsistent to not support > > PERF_SAMPLE_BRANCH_NO_{CYCLES,FLAGS} for PEBS/ARCH-LBR output. > > > > OK. I will support NO_{CYCLES,FLAGS} for PEBS/ARCH-LBR to make the output > consistent. > > > Arguably, we should even support NO_CYCLES for FORMAT_TIME. Yes it's > > daft, but that's what you get for adding the ABI. > > > > I will add another patch to support NO_{CYCLES,FLAGS} for FORMAT_TIME. > > The two patches will be on top of the "Support Architectural LBR" series. > Can I send the two patches in a separate thread? Yes please, I have these queued up, I'll push them out to queue.git shortly so that the robots can have a go.