From: "Paul E. McKenney" <paulmck@kernel.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Hulk Robot <hulkci@huawei.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Josh Triplett <josh@joshtriplett.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] locktorture: make function torture_percpu_rwsem_init() static
Date: Mon, 6 Jul 2020 15:52:57 -0700 [thread overview]
Message-ID: <20200706225257.GP9247@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20200703050527.67249-1-weiyongjun1@huawei.com>
On Fri, Jul 03, 2020 at 01:05:27PM +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> kernel/locking/locktorture.c:569:6: warning:
> symbol 'torture_percpu_rwsem_init' was not declared. Should it be static?
>
> And this function is not used outside of locktorture.c,
> so this commit marks it static.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied, thank you!!!
Thanx, Paul
> ---
> kernel/locking/locktorture.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c
> index 9cfa5e89cff7..62d215b2e39f 100644
> --- a/kernel/locking/locktorture.c
> +++ b/kernel/locking/locktorture.c
> @@ -566,7 +566,7 @@ static struct lock_torture_ops rwsem_lock_ops = {
> #include <linux/percpu-rwsem.h>
> static struct percpu_rw_semaphore pcpu_rwsem;
>
> -void torture_percpu_rwsem_init(void)
> +static void torture_percpu_rwsem_init(void)
> {
> BUG_ON(percpu_init_rwsem(&pcpu_rwsem));
> }
>
prev parent reply other threads:[~2020-07-06 22:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 5:05 Wei Yongjun
2020-07-06 22:52 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706225257.GP9247@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=dave@stgolabs.net \
--cc=hulkci@huawei.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®