From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C18FC433E2 for ; Tue, 7 Jul 2020 15:32:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D01A204EC for ; Tue, 7 Jul 2020 15:32:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594135929; bh=SZMo4lJ02JixxSULEiH5qQ2oMHm5bYU/eZWP5P/FmwY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=LQ9QAeX32unPx1wiMfFqWvL48wSCTPUbSliD/vu617TEVB3z/k1FAGB0Cs2jj2Pb3 ryJJO3DfzDlIphv0ns+eMmxMsKz2/lyMOU7za6KnyJTL17qBjzY1aZvU2yu9THr0Jj mZrf418x2dmQrl4cL5d7VJeQCV9bMlKQTon0HrMc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729863AbgGGPWc (ORCPT ); Tue, 7 Jul 2020 11:22:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:34822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729837AbgGGPWU (ORCPT ); Tue, 7 Jul 2020 11:22:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 256A720773; Tue, 7 Jul 2020 15:22:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594135339; bh=SZMo4lJ02JixxSULEiH5qQ2oMHm5bYU/eZWP5P/FmwY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ILhvWnPgGb5okctaSjC27CeuY0KrpA2Q+zFzi8t7nyKQmP7sqReNCOXERZvykZ6hq gQwPuvXm/fQQSwoFfJUmQDXnJDpU0gQAfajk5YWDuiLww5+rb64nVpDoH4Kwhnd51I ZjTUMuX0kRp+xIjDdQ/Dt9JZSccZxY3pHKC7fBso= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "J. Bruce Fields" , Sasha Levin Subject: [PATCH 5.4 37/65] nfsd: fix nfsdfs inode reference count leak Date: Tue, 7 Jul 2020 17:17:16 +0200 Message-Id: <20200707145754.265692996@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200707145752.417212219@linuxfoundation.org> References: <20200707145752.417212219@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: J. Bruce Fields [ Upstream commit bf2654017e0268cc83dc88d56f0e67ff4406631d ] I don't understand this code well, but I'm seeing a warning about a still-referenced inode on unmount, and every other similar filesystem does a dput() here. Fixes: e8a79fb14f6b ("nfsd: add nfsd/clients directory") Signed-off-by: J. Bruce Fields Signed-off-by: Sasha Levin --- fs/nfsd/nfsctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c index 596ed6a42022d..be418fccc9d86 100644 --- a/fs/nfsd/nfsctl.c +++ b/fs/nfsd/nfsctl.c @@ -1335,6 +1335,7 @@ void nfsd_client_rmdir(struct dentry *dentry) WARN_ON_ONCE(ret); fsnotify_rmdir(dir, dentry); d_delete(dentry); + dput(dentry); inode_unlock(dir); } -- 2.25.1