From: Maxime Chretien <maxime.chretien@bootlin.com>
To: masahiroy@kernel.org
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Maxime Chretien <maxime.chretien@bootlin.com>
Subject: [PATCH] kconfig qconf: Add grey background for hidden options
Date: Wed, 8 Jul 2020 15:30:15 +0200 [thread overview]
Message-ID: <20200708133015.12286-1-maxime.chretien@bootlin.com> (raw)
This is useful to see which configuration parameters can be edited
or not when "Show All Options" is enabled.
Signed-off-by: Maxime Chretien <maxime.chretien@bootlin.com>
---
scripts/kconfig/qconf.cc | 7 +++++++
scripts/kconfig/qconf.h | 4 ++++
2 files changed, 11 insertions(+)
diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
index c0ac8f7b5f1a..be9ff4651da1 100644
--- a/scripts/kconfig/qconf.cc
+++ b/scripts/kconfig/qconf.cc
@@ -208,6 +208,13 @@ void ConfigItem::updateMenu(void)
}
if (!sym_has_value(sym) && visible)
prompt += " (NEW)";
+
+ if(!visible) {
+ setBackground(promptColIdx, QBrush(QColor("#E0E0E0")));
+ } else {
+ setBackground(promptColIdx, QBrush());
+ }
+
set_prompt:
setText(promptColIdx, prompt);
}
diff --git a/scripts/kconfig/qconf.h b/scripts/kconfig/qconf.h
index c879d79ce817..79e47e8c1ae7 100644
--- a/scripts/kconfig/qconf.h
+++ b/scripts/kconfig/qconf.h
@@ -174,6 +174,10 @@ class ConfigItem : public QTreeWidgetItem {
{
return Parent::text(idx);
}
+ void setBackground(colIdx idx, const QBrush& brush)
+ {
+ Parent::setBackground(idx, brush);
+ }
void setPixmap(colIdx idx, const QIcon &icon)
{
Parent::setIcon(idx, icon);
--
2.27.0
next reply other threads:[~2020-07-08 13:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 13:30 Maxime Chretien [this message]
2020-08-07 13:54 ` Masahiro Yamada
2020-08-14 12:28 ` Maxime Chretien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708133015.12286-1-maxime.chretien@bootlin.com \
--to=maxime.chretien@bootlin.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®