From: "Paul E. McKenney" <paulmck@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Kaitao Cheng <pilgrimtao@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] kernel/smp: Fix an off by one in csd_lock_wait_toolong()
Date: Thu, 9 Jul 2020 07:36:30 -0700 [thread overview]
Message-ID: <20200709143630.GY9247@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20200709114900.b475kfqz3447zgfg@linutronix.de>
On Thu, Jul 09, 2020 at 01:49:00PM +0200, Sebastian Andrzej Siewior wrote:
> On 2020-07-09 12:59:06 [+0200], Peter Zijlstra wrote:
> > On Thu, Jul 09, 2020 at 01:48:18PM +0300, Dan Carpenter wrote:
> > > The __per_cpu_offset[] array has "nr_cpu_ids" elements so change the >
> > > >= to prevent a read one element beyond the end of the array.
> > >
> > > Fixes: 0504bc41a62c ("kernel/smp: Provide CSD lock timeout diagnostics")
> >
> > I don't have a copy of that patch in my inbox, even though it says Cc:
> > me.
> >
> > Paul, where do you expect that patch to go? The version I see from my
> > next tree needs a _lot_ of work.
>
> There is also
>
> https://lkml.kernel.org/r/20200705082603.GX3874@shao2-debian
> https://lkml.kernel.org/r/00000000000042f21905a991ecea@google.com
>
> it might be the same thing.
Same commit, different bug, but the fix should be in -next by now.
For these two reports, the problem was that I had debug-recording code
on the wrong side of a csd_unlock().
Thanx, Paul
next prev parent reply other threads:[~2020-07-09 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 10:48 Dan Carpenter
2020-07-09 10:59 ` Peter Zijlstra
2020-07-09 11:49 ` Sebastian Andrzej Siewior
2020-07-09 14:36 ` Paul E. McKenney [this message]
2020-07-09 14:32 ` Paul E. McKenney
2020-07-09 16:59 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709143630.GY9247@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=pilgrimtao@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®