From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE2AFC433DF for ; Fri, 10 Jul 2020 09:04:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B20CD207BC for ; Fri, 10 Jul 2020 09:04:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="sI8NWOcM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727061AbgGJJEa (ORCPT ); Fri, 10 Jul 2020 05:04:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726664AbgGJJE3 (ORCPT ); Fri, 10 Jul 2020 05:04:29 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 720E8C08C5CE for ; Fri, 10 Jul 2020 02:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=n5wCl4iWbIzHQZCe4924XllL45QVL+1NLBDw+elH600=; b=sI8NWOcMHBrWOgoIdWZb0mi7xj fhuSRvRGFLLTFsPeilfzxk2OjspW9Lli5UVJPqNYczvNWvoCNIdRXU+7lU20STRRGkJ2ALPvO0S3i Za/d547vI2qVLMlt80ddV101wWXX7KIYujxcdej1pWNBqLXFgzgWwE7jpAa3Dy/rTsQJyRyX99tVq l051a50IOliy3TVHjoYp39Xpu8R+cfn03MF8VGwAZ1cc9kErpzEtrbTdQs8co8a41No6wk3svAM5g hv6ghgab4jADJtcStI7rjWN5J8tgAFGeNH/6QbupaHP8+mjV78dvOGdv4diW4kGUV/GQXPAaWw7+o 0k+IB7LQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtowe-0008HI-JS; Fri, 10 Jul 2020 09:03:49 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 1EDF3301179; Fri, 10 Jul 2020 11:03:44 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id C4B26214ECE47; Fri, 10 Jul 2020 11:03:44 +0200 (CEST) Date: Fri, 10 Jul 2020 11:03:44 +0200 From: Peter Zijlstra To: Jarkko Sakkinen Cc: linux-kernel@vger.kernel.org, Andi Kleen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu , Steven Rostedt , Andrew Morton , "Aneesh Kumar K.V" , Will Deacon , Kees Cook , Arnd Bergmann , Alexandre Ghiti , Masahiro Yamada , Sami Tolvanen , Peter Collingbourne , Krzysztof Kozlowski , Frederic Weisbecker , Stephen Boyd , Alexei Starovoitov , Mike Rapoport , Sean Christopherson , Jiri Olsa Subject: Re: [PATCH RFC] kprobes: Remove MODULES dependency Message-ID: <20200710090344.GX4800@hirez.programming.kicks-ass.net> References: <20200709234521.194005-1-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200709234521.194005-1-jarkko.sakkinen@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 10, 2020 at 02:45:19AM +0300, Jarkko Sakkinen wrote: > Remove MODULES dependency and migrate from module_alloc to vmalloc(). > According to Andi, the history with this dependency is that kprobes > originally required custom LKM's, which does not hold today anymore. > > Right now one has to compile LKM support only to enable kprobes. With > this change applied, it is somewhat easier to create custom test > kernel's with a proper debugging capabilities, thus making Linux more > developer friendly. > > Cc: Andi Kleen > Signed-off-by: Jarkko Sakkinen NAK this patch is horrific, it sprinkles a metric ton of #ifdef and silently disables a lot of kprobe features (like all the opt stuff). How about unconditionally providing module_alloc() instead?