From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D2EEC433DF for ; Fri, 10 Jul 2020 10:00:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C41E52077D for ; Fri, 10 Jul 2020 10:00:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594375234; bh=wfOjbdLmDRRq6sS+T74nRU6/o+uCYi86CN57IhaKxvo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=BMC4auWi2OOGXNzDsC1bXMeoNmpKcr0g7E0jzqNxCNJs6E95GURnr71RsTmRZ/mG3 mFZBkgGYsf3rSCWYlVe+7HUojnwpzYl9PFmtnLlKHaGfyUyt4OkCQ2/5m8EUVZNwJJ E4aGCLAdvaYK3gojMen9Ujr9a2EH0OQ7eCoZ3h4U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726664AbgGJKAd (ORCPT ); Fri, 10 Jul 2020 06:00:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:35152 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727099AbgGJKAd (ORCPT ); Fri, 10 Jul 2020 06:00:33 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 556F220767; Fri, 10 Jul 2020 10:00:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594375232; bh=wfOjbdLmDRRq6sS+T74nRU6/o+uCYi86CN57IhaKxvo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QsjnfvPdkorgc+lmepmJcD2m1t1QVnCHQfE219nCtEMGf84BVhaIRFJ3qdzTnzTVa 22fYTX5s+Vj/zKmJY+Yvmn8T9e2NRR2iwAIcDqgYD/l11//lDlI+7uBFLkuYYxz553 eJbX+bMPZSmHl8eRSMEZraLUTMTdIhcbzt9Yx/qo= Date: Fri, 10 Jul 2020 12:00:37 +0200 From: Greg KH To: Qiwu Huang Cc: sre@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, jiangfei1@xiaomi.com, Qiwu Huang Subject: Re: [PATCH 2/5] power: supply: core: add wireless charger adapter type property Message-ID: <20200710100037.GB1197607@kroah.com> References: <20200710084841.1933254-1-yanziily@gmail.com> <20200710084841.1933254-2-yanziily@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200710084841.1933254-2-yanziily@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 10, 2020 at 04:48:38PM +0800, Qiwu Huang wrote: > From: Qiwu Huang > > Reports what type of wireless adapter connection is > currently active forthe supply. > for example it can show if ADAPTER_PD capable source is attached. > > Signed-off-by: Qiwu Huang > --- > Documentation/ABI/testing/sysfs-class-power | 13 +++++++++++++ > drivers/power/supply/power_supply_sysfs.c | 1 + > include/linux/power_supply.h | 1 + > 3 files changed, 15 insertions(+) > > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power > index 0d9d6b46e239..2099cf194a89 100644 > --- a/Documentation/ABI/testing/sysfs-class-power > +++ b/Documentation/ABI/testing/sysfs-class-power > @@ -718,3 +718,16 @@ Contact: Fei Jiang > Access: Read-Only > Valid values: "QUICK_CHARGE_NORMAL", "QUICK_CHARGE_FAST", "QUICK_CHARGE_FLASH", > "QUICK_CHARGE_TURBE", "QUICK_CHARGE_SUPER". > + > +===== Wireless Charger Properties ===== > +What: /sys/class/power_supply//tx_adapter > +Date: Jul 2020 > +Contact: Fei Jiang > +Description: > + Reports what type of wireless adapter connection is currently active for > + the supply, for example it can show if ADAPTER_PD capable source > + is attached. > + > + Access: Read-Only > + Valid values: "ADAPTER_NONE", "ADAPTER_SDP", "ADAPTER_DCP", "ADAPTER_CDP", > + "ADAPTER_QC2", "ADAPTER_QC3", "ADAPTER_PD" or other private adapter. Why are these strings not in the patch as well? > \ No newline at end of file > diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c > index f95574c41898..c864a14829ec 100644 > --- a/drivers/power/supply/power_supply_sysfs.c > +++ b/drivers/power/supply/power_supply_sysfs.c > @@ -207,6 +207,7 @@ static struct power_supply_attr power_supply_attrs[] = { > POWER_SUPPLY_ATTR(MANUFACTURER), > POWER_SUPPLY_ATTR(SERIAL_NUMBER), > POWER_SUPPLY_ATTR(quick_charge_type), > + POWER_SUPPLY_ATTR(tx_adapter), upper case? thanks, greg k-h