From: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
To: Melissa Wen <melissa.srw@gmail.com>
Cc: Haneen Mohammed <hamohammed.sa@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kernel-usp@googlegroups.com, twoerner@gmail.com
Subject: Re: [PATCH] drm/vkms: change the max cursor width/height
Date: Sun, 12 Jul 2020 18:11:40 -0400 [thread overview]
Message-ID: <20200712221140.7vzjh4nwtszpffa2@smtp.gmail.com> (raw)
In-Reply-To: <20200712220544.3zmyohuf7cj4y27y@smtp.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1524 bytes --]
Applied to drm-misc-next.
Thanks
On 07/12, Rodrigo Siqueira wrote:
> Hi Melissa,
>
> First of all, thanks a lot for your patch! This is a nice change since
> it increases the code coverage.
>
> Reviewed-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
>
> On 07/10, Melissa Wen wrote:
> > This change expands the coverage for the IGT kms_cursor_crc test, where
> > the size varies between 64 and 512 for a square cursor. With this, in
> > addition to the cursor 64x64, this patch enables the test of cursors with
> > sizes: 128x128, 256x256, and 512x512.
> >
> > Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
> > ---
> > drivers/gpu/drm/vkms/vkms_drv.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> > index 1e8b2169d834..57a8a397d5e8 100644
> > --- a/drivers/gpu/drm/vkms/vkms_drv.c
> > +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> > @@ -133,6 +133,8 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev)
> > dev->mode_config.min_height = YRES_MIN;
> > dev->mode_config.max_width = XRES_MAX;
> > dev->mode_config.max_height = YRES_MAX;
> > + dev->mode_config.cursor_width = 512;
> > + dev->mode_config.cursor_height = 512;
> > dev->mode_config.preferred_depth = 24;
> > dev->mode_config.helper_private = &vkms_mode_config_helpers;
> >
> > --
> > 2.27.0
> >
>
> --
> Rodrigo Siqueira
> https://siqueira.tech
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-07-12 22:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 16:03 Melissa Wen
2020-07-12 22:05 ` Rodrigo Siqueira
2020-07-12 22:11 ` Rodrigo Siqueira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200712221140.7vzjh4nwtszpffa2@smtp.gmail.com \
--to=rodrigosiqueiramelo@gmail.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=kernel-usp@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=melissa.srw@gmail.com \
--cc=twoerner@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®