From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30507C433E8 for ; Mon, 13 Jul 2020 01:56:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02DD4206D9 for ; Mon, 13 Jul 2020 01:56:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728408AbgGMB4e (ORCPT ); Sun, 12 Jul 2020 21:56:34 -0400 Received: from mga02.intel.com ([134.134.136.20]:11551 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726261AbgGMB4d (ORCPT ); Sun, 12 Jul 2020 21:56:33 -0400 IronPort-SDR: fSTj7bQRcEsB1XtstARi7P2B3kqSy4Cgy1UudQq4NUtd2Coiv/Q5lEc9ArK1pJ8Fgrwi2IZXUJ MZgujUHND89w== X-IronPort-AV: E=McAfee;i="6000,8403,9680"; a="136718378" X-IronPort-AV: E=Sophos;i="5.75,345,1589266800"; d="scan'208";a="136718378" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2020 18:56:32 -0700 IronPort-SDR: Zs6lenS7Wgpo3n8w5Vp2sagKfsqwSr7MBh4M5MGPbpuwx84FK+KuMJAKbgXVDysn5amjPIxRj7 cfW9QpGNYa4A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,345,1589266800"; d="scan'208";a="317223746" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.141]) by fmsmga002.fm.intel.com with ESMTP; 12 Jul 2020 18:56:30 -0700 Date: Mon, 13 Jul 2020 09:52:24 +0800 From: Xu Yilun To: Moritz Fischer Cc: "Wu, Hao" , Tom Rix , "linux-fpga@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lgoncalv@redhat.com" , Matthew Gerlach , "Weight, Russell H" , yilun.xu@intel.com Subject: Re: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000 Message-ID: <20200713015224.GA2624@yilunxu-OptiPlex-7050> References: <1594282705-32289-1-git-send-email-yilun.xu@intel.com> <20200709093527.GA32541@yilunxu-OptiPlex-7050> <2d7919d5-a320-58f4-5c9d-7ef868ad8676@redhat.com> <20200710052443.GB8689@yilunxu-OptiPlex-7050> <20200710154616.GA130068@epycbox.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200710154616.GA130068@epycbox.lan> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 10, 2020 at 08:46:16AM -0700, Moritz Fischer wrote: > On Fri, Jul 10, 2020 at 06:14:19AM +0000, Wu, Hao wrote: > > > On Thu, Jul 09, 2020 at 06:00:40AM -0700, Tom Rix wrote: > > > > > > > > On 7/9/20 3:14 AM, Wu, Hao wrote: > > > > >> On Thu, Jul 09, 2020 at 05:10:49PM +0800, Wu, Hao wrote: > > > > >>>> Subject: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000 > > > > >>>> > > > > >>>> Add PCIe Device ID for Intel FPGA PAC N3000. > > > > >>>> > > > > >>>> Signed-off-by: Wu Hao > > > > >>>> Signed-off-by: Xu Yilun > > > > >>>> Signed-off-by: Matthew Gerlach > > > > >>>> Signed-off-by: Russ Weight > > > > >>>> --- > > > > >>>> drivers/fpga/dfl-pci.c | 2 ++ > > > > >>>> 1 file changed, 2 insertions(+) > > > > >>>> > > > > >>>> diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c > > > > >>>> index 73b5153..824aecf 100644 > > > > >>>> --- a/drivers/fpga/dfl-pci.c > > > > >>>> +++ b/drivers/fpga/dfl-pci.c > > > > >>>> @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev > > > *pcidev) > > > > >>>> #define PCIE_DEVICE_ID_PF_INT_5_X0xBCBD > > > > >>>> #define PCIE_DEVICE_ID_PF_INT_6_X0xBCC0 > > > > >>>> #define PCIE_DEVICE_ID_PF_DSC_1_X0x09C4 > > > > >>>> +#define PCIE_DEVICE_ID_PF_PAC_N3000 0x0B30 > > > > >>> Should we drop _PF_ here? and also do you want _INTEL_ here? > > > > >> I think we could keep _PF_, also there is no need to support VF of pac > > > > >> n3000 in product now, but it does exist (ID: 0x0b31). > > > > > > > > I was wondering about the vf id, thanks! > > > > > > > > >> > > > > >> And add _INTEL_ is good to me. > > > > >> > > > > >> Then how about this one: > > > > >> #define PCIE_DEVICE_ID_PF_INTEL_PAC_N3000 0x0B30 > > > > > I am just considering the alignment with ids defined in > > > include/linux/pci_ids.h > > > > > So drop _PF_ before _INTEL_ would be better? : ) > > > > > > > > To be consistent, all the id's are intel and all could drop pf. > > > > > > That's good to me after checking the pci_ids.h. So we have: > > > > > > #define PCIE_DEVICE_ID_INTEL_PAC_N3000 0x0B30 > > > > Sounds good to me. > > > > Hao > > Heads up I was gonna send out the PR early next week. I can fix this up > myself if you want if you want or you can resend it? I sent the v2 patch for this. Please help check it. Thanks, Yilun > > Thanks, > Moritz