From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07342C433E0 for ; Mon, 13 Jul 2020 12:26:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2EE120738 for ; Mon, 13 Jul 2020 12:26:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729683AbgGMM0l (ORCPT ); Mon, 13 Jul 2020 08:26:41 -0400 Received: from foss.arm.com ([217.140.110.172]:59566 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729259AbgGMM0l (ORCPT ); Mon, 13 Jul 2020 08:26:41 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 78D3930E; Mon, 13 Jul 2020 05:26:40 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0F05E3F887; Mon, 13 Jul 2020 05:26:38 -0700 (PDT) Date: Mon, 13 Jul 2020 13:26:37 +0100 From: Mark Rutland To: Christoph Hellwig Cc: Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Andrew Morton , Linus Torvalds , linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] uaccess: add force_uaccess_{begin,end} helpers Message-ID: <20200713122636.GB51007@lakrids.cambridge.arm.com> References: <20200710135706.537715-1-hch@lst.de> <20200710135706.537715-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200710135706.537715-6-hch@lst.de> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 10, 2020 at 03:57:05PM +0200, Christoph Hellwig wrote: > Add helpers to wraper the get_fs/set_fs magic for undoing any damange > done by set_fs(KERNEL_DS). There is no real functional benefit, but this > documents the intent of these calls better, and will allow stubbing the > functions out easily for kernels builds that do not allow address space > overrides in the future. > > Signed-off-by: Christoph Hellwig > --- > arch/arm64/kernel/sdei.c | 2 +- > arch/m68k/include/asm/tlbflush.h | 12 ++++++------ > arch/mips/kernel/unaligned.c | 27 +++++++++++++-------------- > arch/nds32/mm/alignment.c | 7 +++---- > arch/sh/kernel/traps_32.c | 18 ++++++++---------- > drivers/firmware/arm_sdei.c | 5 ++--- > include/linux/uaccess.h | 18 ++++++++++++++++++ > kernel/events/callchain.c | 5 ++--- > kernel/events/core.c | 5 ++--- > kernel/kthread.c | 5 ++--- > kernel/stacktrace.c | 5 ++--- > mm/maccess.c | 22 ++++++++++------------ > 12 files changed, 69 insertions(+), 62 deletions(-) The perf core and arm64/sdei bits look sound. FWIW: Acked-by: Mark Rutland Mark.