From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C26FCC433E2 for ; Mon, 13 Jul 2020 20:43:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9710B2075B for ; Mon, 13 Jul 2020 20:43:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="mS3cZkkL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726834AbgGMUnG (ORCPT ); Mon, 13 Jul 2020 16:43:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726338AbgGMUnG (ORCPT ); Mon, 13 Jul 2020 16:43:06 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE295C061755 for ; Mon, 13 Jul 2020 13:43:05 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id i62so17094949ybc.15 for ; Mon, 13 Jul 2020 13:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc :content-transfer-encoding; bh=u4BPyWh5yHs2Kab6PgpImYecSjjyYcaQmgcBiUoACx4=; b=mS3cZkkL4ytB2Rv9TXb6i3g2Jr9fxMLvGOFLgmKO9mjkEr2Y/YJXB0wtQJLK+1GUOk nu95u4fibL1kpfO/8a2bC1HCfJzeJp0nIGY9Y/mE7n8753iaBgxcgy6Sb77+8E+wOiXT kQw87UJdQEJlo2BV8MJb+FknKPXT2a6vUbZEFT0Lt5IXOX2gPrrkYCf93BhKjdM5bPtX FM4KoYL67nCmJccP4NUqatEwEDkkHIDJS2/U6Xup2+IyYS0WEtM+zmCqpW19mGTKAXiS Nw/l/lUA84twskulRUy5b0xMobsP53aJ+/mb537ln0Mk4IKTtxC7EAxxJLNUo749fkwv 3f1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc :content-transfer-encoding; bh=u4BPyWh5yHs2Kab6PgpImYecSjjyYcaQmgcBiUoACx4=; b=pSvaVphQ7fkxv5L3OqynfEXZZ3q23eQ6hViuqVifuogsQyuZcI/B8DphnYmOzsm6HC qyuCTCECD1kBJMrQFm+DnzEmIYHYBoOpEcVBjLMvRbiwmLeskzQFInfAOUammH3jjNjB /SJWXUHkMDUYl7YzurUJUmBEeGp76buSHb+lbxNklDGSihqjWzhzwRmJlXKdv5+AgGA+ T1iVUByXaB053bfFirJIzby+EAk9EngJGySu1GA4r+2E/OOutSNAiSwCkGkVsbWQuvFR GHn1pgKvhWvOUx/TlY3grySbGjP3i4lpqpN/ES87UTli34/OQlNhCmgMgSNIaVbOJjeR 97wQ== X-Gm-Message-State: AOAM532UCQo876AZ/hIJ6Rthjlye680wK8RtaP29ijZQiBq2CH0fsI0x GBnL4Hnqftd3nt2zgyORSCgZPQxE9cw= X-Google-Smtp-Source: ABdhPJzJrI8P+vDGu8F5oFZf2kl4M+ReMzqn9ChOp7gZBgsfRmaAQsCbSphkOs/bWdkme8nxrxWW/k2ufws= X-Received: by 2002:a25:d80b:: with SMTP id p11mr2915414ybg.506.1594672984919; Mon, 13 Jul 2020 13:43:04 -0700 (PDT) Date: Mon, 13 Jul 2020 13:43:00 -0700 Message-Id: <20200713204300.345975-1-badhri@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.27.0.383.g050319c2ae-goog Subject: [PATCH] usb: typec: tcpm: Move to high priority workqueue for processing events From: Badhri Jagan Sridharan To: Guenter Roeck , Heikki Krogerus , reg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Badhri Jagan Sridharan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "tReceiverResponse 15 ms Section 6.6.2 The receiver of a Message requiring a response Shall respond within tReceiverResponse in order to ensure that the sender=E2=80=99s SenderResponseTimer does not expire." When the cpu complex is busy running other lower priority work items, TCPM's work queue sometimes does not get scheduled on time to meet the above requirement from the spec. Elevating the TCPM's work queue to higher priority allows TCPM to meet tReceiverResponse in a busy system. Signed-off-by: Badhri Jagan Sridharan --- drivers/usb/typec/tcpm/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index 82b19ebd7838e0..088b6f1fa1ff89 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -4747,7 +4747,7 @@ struct tcpm_port *tcpm_register_port(struct device *d= ev, struct tcpc_dev *tcpc) mutex_init(&port->lock); mutex_init(&port->swap_lock); =20 - port->wq =3D create_singlethread_workqueue(dev_name(dev)); + port->wq =3D alloc_ordered_workqueue("%s", WQ_HIGHPRI, dev_name(dev)); if (!port->wq) return ERR_PTR(-ENOMEM); INIT_DELAYED_WORK(&port->state_machine, tcpm_state_machine_work); --=20 2.27.0.383.g050319c2ae-goog