From: Xu Yilun <yilun.xu@intel.com>
To: Tom Rix <trix@redhat.com>
Cc: mdf@kernel.org, linux-fpga@vger.kernel.org,
linux-kernel@vger.kernel.org, lgoncalv@redhat.com,
Wu Hao <hao.wu@intel.com>,
Matthew Gerlach <matthew.gerlach@linux.intel.com>,
Russ Weight <russell.h.weight@intel.com>
Subject: Re: [PATCH v2] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
Date: Tue, 14 Jul 2020 14:01:08 +0800 [thread overview]
Message-ID: <20200714060108.GA27430@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <4efe6ee9-4e88-5b31-01a2-414f752a3d2e@redhat.com>
On Mon, Jul 13, 2020 at 07:36:26AM -0700, Tom Rix wrote:
>
> > @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev *pcidev)
> > #define PCIE_DEVICE_ID_PF_INT_5_X 0xBCBD
> > #define PCIE_DEVICE_ID_PF_INT_6_X 0xBCC0
> > #define PCIE_DEVICE_ID_PF_DSC_1_X 0x09C4
> > +#define PCIE_DEVICE_ID_INTEL_PAC_N3000 0x0B30
>
> My point about consistency. These are all intel and all should have their pf parts removed.
>
> #define PCIE_DEVICE_ID_INTEL_INT_5_X 0xBCBD
> #define PCIE_DEVICE_ID_INTEL_INT_6_X 0xBCC0
> #define PCIE_DEVICE_ID_INTEL_DSC_1_X 0x09C4
>
> Let's revisit this for the d5005.
I agree that we should be consistent on the naming. I think we could
reconsider the naming of previous cards and submit a new patch for them.
>
> trix
>
prev parent reply other threads:[~2020-07-14 6:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 1:47 Xu Yilun
2020-07-13 2:02 ` Moritz Fischer
2020-07-13 14:36 ` Tom Rix
2020-07-14 6:01 ` Xu Yilun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714060108.GA27430@yilunxu-OptiPlex-7050 \
--to=yilun.xu@intel.com \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=mdf@kernel.org \
--cc=russell.h.weight@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®