From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C96FC433E0 for ; Tue, 14 Jul 2020 06:09:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB04420890 for ; Tue, 14 Jul 2020 06:09:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726617AbgGNGJ3 (ORCPT ); Tue, 14 Jul 2020 02:09:29 -0400 Received: from mga11.intel.com ([192.55.52.93]:58184 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725306AbgGNGJ3 (ORCPT ); Tue, 14 Jul 2020 02:09:29 -0400 IronPort-SDR: 3Ulr9QZDjdEk+ZChUWy35VWBdbRzbF6Gz56s5WCq2il0w+GxLtg7QXbFLXynXoSQW1kE8Y/DY6 WCh71YSasViw== X-IronPort-AV: E=McAfee;i="6000,8403,9681"; a="146832768" X-IronPort-AV: E=Sophos;i="5.75,350,1589266800"; d="scan'208";a="146832768" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2020 23:09:29 -0700 IronPort-SDR: jZ8IUhMWHZKyP8xm/ws5+WCpd0V2bb2/PzO8wZBd4diPNT5BNXwy9mnQ7zIBW9QejaRC1c0YG4 uj8I8Zcy1+fQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,350,1589266800"; d="scan'208";a="390386995" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.141]) by fmsmga001.fm.intel.com with ESMTP; 13 Jul 2020 23:09:27 -0700 Date: Tue, 14 Jul 2020 14:05:20 +0800 From: Xu Yilun To: Lee Jones Cc: linux-kernel@vger.kernel.org, trix@redhat.com, matthew.gerlach@linux.intel.com, russell.h.weight@intel.com, lgoncalv@redhat.com, Wu Hao , yilun.xu@intel.com Subject: Re: [PATCH 1/2] mfd: intel-m10-bmc: add Max10 BMC chip support for Intel FPGA PAC Message-ID: <20200714060520.GA27975@yilunxu-OptiPlex-7050> References: <1594614896-16606-1-git-send-email-yilun.xu@intel.com> <1594614896-16606-2-git-send-email-yilun.xu@intel.com> <20200713091708.GC3500@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200713091708.GC3500@dell> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 13, 2020 at 10:17:08AM +0100, Lee Jones wrote: > On Mon, 13 Jul 2020, Xu Yilun wrote: > > > This patch implements the basic functions of the BMC chip for some Intel > > FPGA PCIe Acceleration Cards (PAC). The BMC is implemented using the > > intel max10 CPLD. > > > > This BMC chip is connected to FPGA by a SPI bus. To provide reliable > > register access from FPGA, an Avalon Memory-Mapped (Avmm) transaction > > protocol over the SPI bus is used between host and slave. > > > > This driver implements the basic register access with the regmap framework. > > The mfd cells array is empty now as a placeholder. > > > > Signed-off-by: Xu Yilun > > Signed-off-by: Wu Hao > > Signed-off-by: Matthew Gerlach > > Signed-off-by: Russ Weight > > Signed-off-by: Tom Rix > > --- > > .../ABI/testing/sysfs-driver-intel-m10-bmc | 15 + > > drivers/mfd/Kconfig | 13 + > > drivers/mfd/Makefile | 3 + > > drivers/mfd/intel-m10-bmc-main.c | 176 ++++ > > > drivers/mfd/intel-spi-avmm.c | 904 +++++++++++++++++++++ > > This does not belong in MFD. > > Please consider moving it to drivers/spi. OK, I could make the intel-spi-avmm.c as a separate module in other folder. Since it is an implementation of regmap, is it better we move it to drivers/base/regmap? > > > drivers/mfd/intel-spi-avmm.h | 35 + > > include/linux/mfd/intel-m10-bmc.h | 57 ++ > > 7 files changed, 1203 insertions(+) > > create mode 100644 Documentation/ABI/testing/sysfs-driver-intel-m10-bmc > > create mode 100644 drivers/mfd/intel-m10-bmc-main.c > > create mode 100644 drivers/mfd/intel-spi-avmm.c > > create mode 100644 drivers/mfd/intel-spi-avmm.h > > create mode 100644 include/linux/mfd/intel-m10-bmc.h > > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog