From: Mark Brown <broonie@kernel.org>
To: xingxing qiao <mnlife@foxmail.com>
Cc: lgirdwood <lgirdwood@gmail.com>, perex <perex@perex.cz>,
linux-kernel <linux-kernel@vger.kernel.org>,
alsa-devel <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] When snd_soc_card_jack_new is not called or the call fails, calling this function causes a null pointer access
Date: Tue, 14 Jul 2020 15:45:17 +0100 [thread overview]
Message-ID: <20200714144517.GF4900@sirena.org.uk> (raw)
In-Reply-To: <tencent_AA2F5D7A5EDC40E7E806D0CA5877CE8AB308@qq.com>
[-- Attachment #1: Type: text/plain, Size: 410 bytes --]
On Tue, Jul 14, 2020 at 10:30:36PM +0800, xingxing qiao wrote:
> unsigned int sync = 0;
> int enable;
>
> -if (!jack)
This is actually worse than your previous posting - it's got HTML all
through it :( git send-email is typically the easiest way to send
things.
Also please note my comment about needing a subject line in a similar
style to those in existing commits you can see in git.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
parent reply other threads:[~2020-07-14 14:45 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <tencent_AA2F5D7A5EDC40E7E806D0CA5877CE8AB308@qq.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714144517.GF4900@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mnlife@foxmail.com \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®