From: Stephen Rothwell <sfr@canb.auug.org.au>
To: dillon.minfei@gmail.com
Cc: bcousson@baylibre.com, tony@atomide.com, robh+dt@kernel.org,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] Fix dcan driver probe failed on am437x platform
Date: Tue, 14 Jul 2020 16:45:04 +1000 [thread overview]
Message-ID: <20200714164504.10b23697@canb.auug.org.au> (raw)
In-Reply-To: <1594708507-6794-2-git-send-email-dillon.minfei@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
Hi Dillon,
> Hi Stephen,
>
> This changes correct commit messages based on your reviewing.
> make Fixes tags to oneline.
> make all commit message tags at the end of commit message
> make Fixes tags before Signed-off-by line.
> add probe failed log to commit message.
Thanks for persisting. It looks good to me, now.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-14 6:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 6:35 [PATCH v4] ARM: dts: Configure osc clock for d_can on am437x dillon.minfei
2020-07-14 6:35 ` [PATCH v4] Fix dcan driver probe failed on am437x platform dillon.minfei
2020-07-14 6:45 ` Stephen Rothwell [this message]
2020-07-14 7:02 ` dillon min
2020-07-14 15:13 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714164504.10b23697@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dillon.minfei@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®