mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
Cc: linux-arm-kernel@lists.infradead.org,
	Lee Jones <lee.jones@linaro.org>,
	Furquan Shaikh <furquan@chromium.org>,
	Raul E Rangel <rrangel@chromium.org>,
	Eric Peers <epeers@google.com>,
	Duncan Laurie <dlaurie@google.com>,
	Benson Leung <bleung@chromium.org>,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Guenter Roeck <groeck@chromium.org>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	Rob Herring <robh@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart"
Date: Wed, 15 Jul 2020 09:56:30 +0200	[thread overview]
Message-ID: <20200715075630.GB2514306@kroah.com> (raw)
In-Reply-To: <20200715074131.1754203-1-bhanumaiya@google.com>

On Wed, Jul 15, 2020 at 12:41:31AM -0700, Bhanu Prakash Maiya wrote:
> From: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> 
> Add DT compatible string in
> Documentation/devicetree/bindings/mfd/cros_ec.txt
> 
> Series-to: LKML <linux-kernel@vger.kernel.org>
> Series-cc: Raul E Rangel <rrangel@chromium.org>, Furquan Shaikh <furquan@chromium.org>, Duncan Laurie <dlaurie@google.com>, Eric Peers <epeers@google.com>, Benson Leung <bleung@chromium.org>, Enric Balletbo i Serra <enric.balletbo@collabora.com>, Guenter Roeck <groeck@chromium.org>, linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org

That looks a bit odd, don't you think?

> Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
> Change-Id: Icfeab15fa04daaffc61280faf5a75cd9b23ee822

Again, checkpatch.pl is your friend.

thanks,

greg k-h

  reply	other threads:[~2020-07-15  7:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15  7:41 Bhanu Prakash Maiya
2020-07-15  7:56 ` Greg Kroah-Hartman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-06-25 21:34 [PATCH 1/2] cros: platform/chrome: Add cros-ec-uart driver for uart support Bhanu Prakash Maiya
2020-06-25 21:34 ` [PATCH 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart" Bhanu Prakash Maiya
2020-06-26  8:42   ` Enric Balletbo i Serra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200715075630.GB2514306@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bhanumaiya@chromium.org \
    --cc=bleung@chromium.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dlaurie@google.com \
    --cc=enric.balletbo@collabora.com \
    --cc=epeers@google.com \
    --cc=furquan@chromium.org \
    --cc=groeck@chromium.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=robh@kernel.org \
    --cc=rrangel@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®