From: Greg KH <gregkh@linuxfoundation.org>
To: Arpitha Raghunandan <98.arpi@gmail.com>
Cc: Larry.Finger@lwfinger.net, puranjay12@gmail.com,
yepeilin.cs@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8188eu: core: fix coding style issues
Date: Wed, 15 Jul 2020 17:24:19 +0200 [thread overview]
Message-ID: <20200715152419.GA722895@kroah.com> (raw)
In-Reply-To: <20200715142710.76205-1-98.arpi@gmail.com>
On Wed, Jul 15, 2020 at 07:57:10PM +0530, Arpitha Raghunandan wrote:
> Fixing WARNING: Prefer using '"%s...", __func__' to using 'function_name'
> in a string in rtw_ioctl_set.c
>
> Signed-off-by: Arpitha Raghunandan <98.arpi@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
What changed from v1?
Always put that information below the --- line in the patch like the
documentation asks.
Can you fix this up and send v3?
thanks,
greg k-h
prev parent reply other threads:[~2020-07-15 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 14:27 Arpitha Raghunandan
2020-07-15 15:24 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715152419.GA722895@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=98.arpi@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puranjay12@gmail.com \
--cc=yepeilin.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®