From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Hemant Kumar <hemantk@codeaurora.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH] mhi: fix doubled words and struct image_info kernel-doc
Date: Thu, 16 Jul 2020 08:41:24 +0530 [thread overview]
Message-ID: <20200716031124.GC3271@Mani-XPS-13-9360> (raw)
In-Reply-To: <cab64692-31f6-5a2b-a540-aa434d35f9a9@infradead.org>
On Wed, Jul 15, 2020 at 06:29:32PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Drop doubled word "table" in kernel-doc.
> Fix syntax for the kernel-doc notation for struct image_info.
> Note that the bhi_vec field is private and not part of the kernel-doc.
>
> Drop doubled word "device" in a comment.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Applied to mhi-next!
Thanks,
Mani
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Cc: Hemant Kumar <hemantk@codeaurora.org>
> Cc: linux-arm-msm@vger.kernel.org
> ---
> include/linux/mhi.h | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> --- linux-next-20200714.orig/include/linux/mhi.h
> +++ linux-next-20200714/include/linux/mhi.h
> @@ -85,13 +85,15 @@ enum mhi_ch_type {
> };
>
> /**
> - * struct image_info - Firmware and RDDM table table
> - * @mhi_buf - Buffer for firmware and RDDM table
> - * @entries - # of entries in table
> + * struct image_info - Firmware and RDDM table
> + * @mhi_buf: Buffer for firmware and RDDM table
> + * @entries: # of entries in table
> */
> struct image_info {
> struct mhi_buf *mhi_buf;
> + /* private: from internal.h */
> struct bhi_vec_entry *bhi_vec;
> + /* public: */
> u32 entries;
> };
>
> @@ -593,7 +595,7 @@ int mhi_async_power_up(struct mhi_contro
>
> /**
> * mhi_sync_power_up - Start MHI power up sequence and wait till the device
> - * device enters valid EE state
> + * enters valid EE state
> * @mhi_cntrl: MHI controller
> */
> int mhi_sync_power_up(struct mhi_controller *mhi_cntrl);
>
prev parent reply other threads:[~2020-07-16 3:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 1:29 Randy Dunlap
2020-07-16 3:01 ` Manivannan Sadhasivam
2020-07-16 3:11 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716031124.GC3271@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®