From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7400C433E8 for ; Thu, 16 Jul 2020 12:38:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84A4120760 for ; Thu, 16 Jul 2020 12:38:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=megous.com header.i=@megous.com header.b="twsJ8dEY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728745AbgGPMiW (ORCPT ); Thu, 16 Jul 2020 08:38:22 -0400 Received: from vps.xff.cz ([195.181.215.36]:42166 "EHLO vps.xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728237AbgGPMiO (ORCPT ); Thu, 16 Jul 2020 08:38:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1594903092; bh=qYblAUDIZRO1zNd6viLmd487utSDKXeq71xAotYuRG8=; h=From:To:Cc:Subject:Date:From; b=twsJ8dEYPvij0y+AoCQWI6o/pVtQvDIcj3LZsx/fOE5i4Z04daXViaOC8tLUCcaiM 5hsXrmtHlJ1vhTOfwZ4apIEonmeA5qbNcz/hHec+VEJ7h4Y7GPpat90ApH78CYsxuE uBk1Rl0P/nqZIO7Fs0HJx0O9g+jIYUE8crInr9Zs= From: Ondrej Jirman To: David Airlie , Daniel Vetter , Thierry Reding , Sam Ravnborg , Fabio Estevam , =?UTF-8?q?Guido=20G=C3=BCnther?= , Robert Chiras Cc: Ondrej Jirman , Samuel Holland , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/2] Fix st7703 panel initialization failures Date: Thu, 16 Jul 2020 14:37:51 +0200 Message-Id: <20200716123753.3552425-1-megous@megous.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When extending the driver for xbd599 panel support I tried to do minimal changes and keep the existing initialization timing. It turned out that it's not good enough and the existing init sequence is too aggressive and doesn't follow the specification. On PinePhone panel is being powered down/up during suspend/resume and with current timings this frequently leads to corrupted display. This patch series fixes the problems. The issue was reported by Samuel Holland. Relevant screenshots from the datasheet: Power on timing: https://megous.com/dl/tmp/35b72e674ce0ca27.png Power off timing: https://megous.com/dl/tmp/dea195517106ff17.png More optimal reset on poweron: https://megous.com/dl/tmp/a9e5caf14e1b0dc6.png Less optimal reset on poweron: https://megous.com/dl/tmp/246761039283c4cf.png Datasheet: https://megous.com/dl/tmp/ST7703_DS_v01_20160128.pdf Please take a look. thank you and regards, Ondrej Jirman Ondrej Jirman (2): drm/panel: st7703: Make the sleep exit timing match the spec drm/panel: st7703: Fix the power up sequence of the panel drivers/gpu/drm/panel/panel-sitronix-st7703.c | 29 ++++++++++--------- 1 file changed, 15 insertions(+), 14 deletions(-) -- 2.27.0