From: David Miller <davem@davemloft.net>
To: wanghai38@huawei.com
Cc: vishal@chelsio.com, kuba@kernel.org, jeff@garzik.org,
divy@chelsio.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: cxgb3: add missed destroy_workqueue in cxgb3 probe failure
Date: Fri, 17 Jul 2020 18:39:13 -0700 (PDT) [thread overview]
Message-ID: <20200717.183913.1150846066923869608.davem@davemloft.net> (raw)
In-Reply-To: <20200717062117.8941-1-wanghai38@huawei.com>
From: Wang Hai <wanghai38@huawei.com>
Date: Fri, 17 Jul 2020 14:21:17 +0800
> The driver forgets to call destroy_workqueue when cxgb3 probe fails.
> Add the missed calls to fix it.
>
> Fixes: 4d22de3e6cc4 ("Add support for the latest 1G/10G Chelsio adapter, T3.")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
You have to handle the case that the probing of one or more devices
fails yet one or more others succeed.
And you can't know in advance how this will play out.
This is why the workqueue is unconditionally created, and only destroyed
on module remove.
next prev parent reply other threads:[~2020-07-18 1:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 6:21 Wang Hai
2020-07-18 1:39 ` David Miller [this message]
2020-07-18 7:57 ` wanghai (M)
2020-07-17 19:18 Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717.183913.1150846066923869608.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=divy@chelsio.com \
--cc=jeff@garzik.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vishal@chelsio.com \
--cc=wanghai38@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®