From: David Miller <davem@davemloft.net>
To: zhangchangzhong@huawei.com
Cc: mark.einon@gmail.com, kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: ethernet: et131x: Remove unused variable 'pm_csr'
Date: Fri, 17 Jul 2020 18:43:59 -0700 (PDT) [thread overview]
Message-ID: <20200717.184359.1727120553942218221.davem@davemloft.net> (raw)
In-Reply-To: <1594982010-30679-1-git-send-email-zhangchangzhong@huawei.com>
From: Zhang Changzhong <zhangchangzhong@huawei.com>
Date: Fri, 17 Jul 2020 18:33:30 +0800
> Gcc report warning as follows:
>
> drivers/net/ethernet/agere/et131x.c:953:6: warning:
> variable 'pm_csr' set but not used [-Wunused-but-set-variable]
> 953 | u32 pm_csr;
> | ^~~~~~
> drivers/net/ethernet/agere/et131x.c:1002:6:warning:
> variable 'pm_csr' set but not used [-Wunused-but-set-variable]
> 1002 | u32 pm_csr;
> | ^~~~~~
> drivers/net/ethernet/agere/et131x.c:3446:8: warning:
> variable 'pm_csr' set but not used [-Wunused-but-set-variable]
> 3446 | u32 pm_csr;
> | ^~~~~~
>
> After commit 38df6492eb51 ("et131x: Add PCIe gigabit ethernet driver
> et131x to drivers/net"), 'pm_csr' is never used in these functions,
> so removing it to avoid build warning.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Applied.
prev parent reply other threads:[~2020-07-18 1:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 10:33 Zhang Changzhong
2020-07-17 12:57 ` Mark Einon
2020-07-18 1:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717.184359.1727120553942218221.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.einon@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®