From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: B K Karthik <bkkarthik@pesu.pes.edu>
Cc: Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Vlastimil Babka <vbabka@suse.cz>,
Xiyu Yang <xiyuyang19@fudan.edu.cn>,
Michel Lespinasse <walken@google.com>,
Divyansh Kamboj <kambojdivyansh2000@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] staging: comedi: comedi_fops.c: added casts to get rid of sparse warnings
Date: Fri, 17 Jul 2020 12:07:38 +0200 [thread overview]
Message-ID: <20200717100738.GB2553180@kroah.com> (raw)
In-Reply-To: <20200716152548.mzau4zhurwkzp5p6@pesu-pes-edu>
On Thu, Jul 16, 2020 at 11:25:48AM -0400, B K Karthik wrote:
> fixed sparse warnings by adding a cast in assignment from
> void [noderef] __user * to unsigned int __force *
> and a reverse cast in argument from
> unsigned int * to unsigned int __user * .
>
> v1 -> v2:
> - Add a reverse cast in argument
> v2 -> v3:
> - Change commit description as suggested by Ian Abott
> v3 -> v4:
> - Add versioning information in commit description
As Ian said, all of that goes below the --- line so it will not show up
in the changelog text.
As I don't want to hand-edit changelog text, as it does not scale, can
you please fix this up and resend as a v5?
thanks,
greg k-h
prev parent reply other threads:[~2020-07-17 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 15:25 B K Karthik
2020-07-17 9:47 ` Ian Abbott
2020-07-17 10:07 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717100738.GB2553180@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=bkkarthik@pesu.pes.edu \
--cc=devel@driverdev.osuosl.org \
--cc=hsweeten@visionengravers.com \
--cc=kambojdivyansh2000@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=walken@google.com \
--cc=xiyuyang19@fudan.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®