From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A87EAC433DF for ; Fri, 17 Jul 2020 23:04:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C9822070E for ; Fri, 17 Jul 2020 23:04:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726843AbgGQXEm (ORCPT ); Fri, 17 Jul 2020 19:04:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726399AbgGQXEm (ORCPT ); Fri, 17 Jul 2020 19:04:42 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABDE4C0619D3 for ; Fri, 17 Jul 2020 16:04:41 -0700 (PDT) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jwZP9-0006OI-0R; Sat, 18 Jul 2020 01:04:35 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1jwZP8-0003RR-07; Sat, 18 Jul 2020 01:04:34 +0200 Date: Sat, 18 Jul 2020 01:04:31 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Scott Branden Cc: Thierry Reding , Lee Jones , BCM Kernel Feedback , linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, Rayagonda Kokatanur Subject: Re: [PATCH v2] pwm: bcm-iproc: handle clk_get_rate() return Message-ID: <20200717230431.4oj44cfnkhkd2o6z@pengutronix.de> References: <20200717182512.26001-1-scott.branden@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5ahgp5eqlhd5enic" Content-Disposition: inline In-Reply-To: <20200717182512.26001-1-scott.branden@broadcom.com> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5ahgp5eqlhd5enic Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 17, 2020 at 11:25:12AM -0700, Scott Branden wrote: > From: Rayagonda Kokatanur >=20 > Handle clk_get_rate() returning <=3D 0 condition to avoid > possible division by zero. You advertise handling <=3D 0, but in the code only =3D=3D 0 is checked. One of the two is wrong ... Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --5ahgp5eqlhd5enic Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAl8SLnwACgkQwfwUeK3K 7AmfdwgAk8gWLxkwQKT9ApRiJ25C12PNu+T1nJQzle/itAdvq83W5gP6Lzud1iOh a8px2Q5xIP20aHy5Z21OCUOzxqDl7+9o6kczLPLvJesanMC0+DCwBzkyQp/Vs/Kq kSX+mdliVsMZGe0YVlXtuFtss1cs04KksXD0Ge1gMlciEXywgPMYhh0edJg53zKT 9jJ5NtV7tiNKacdSODSfdK6Z8KTTqzK36V+ZFWVzFZkJ9nk1XS7y1rbuC6unlK7O 2mPfE/QuKuP7tmslau5ejLlBZKoVS3qFeAFMzmaI/3HxMuML87XkMwz8ophU3TLl sEZOpcLNEK2sPvO1T0WVo+PBtnEpuQ== =6nzc -----END PGP SIGNATURE----- --5ahgp5eqlhd5enic--