Re: [PATCH 1/2] f2fs: add sysfs symbolic link to kobject with volume name

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2572 bytes --]

Hi Daeho,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on f2fs/dev-test]
[also build test WARNING on linux/master linus/master v5.8-rc5 next-20200717]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Daeho-Jeong/f2fs-add-sysfs-symbolic-link-to-kobject-with-volume-name/20200719-134628
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
config: s390-randconfig-s032-20200719 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.2-49-g707c5017-dirty
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> fs/f2fs/sysfs.c:915:36: sparse: sparse: incorrect type in argument 1 (different base types) @@     expected unsigned short const [usertype] *pwcs @@     got restricted __le16 * @@
>> fs/f2fs/sysfs.c:915:36: sparse:     expected unsigned short const [usertype] *pwcs
>> fs/f2fs/sysfs.c:915:36: sparse:     got restricted __le16 *

vim +915 fs/f2fs/sysfs.c

   909	
   910	static int f2fs_load_syslink(struct f2fs_sb_info *sbi)
   911	{
   912		int idx, count, ret;
   913	
   914		down_read(&sbi->sb_lock);
 > 915		count = utf16s_to_utf8s(sbi->raw_super->volume_name,
   916				ARRAY_SIZE(sbi->raw_super->volume_name),
   917				UTF16_LITTLE_ENDIAN, sbi->syslink_name,
   918				MAX_VOLUME_NAME);
   919		up_read(&sbi->sb_lock);
   920	
   921		if (!count)
   922			return -ENOENT;
   923	
   924		for (idx = 0; idx < MAX_DUP_NUM; idx++) {
   925			snprintf(sbi->syslink_name + count, MAX_DUP_NAME, "_%d", idx);
   926			ret = sysfs_create_link(&f2fs_kset.kobj, &sbi->s_kobj,
   927					sbi->syslink_name);
   928			if (ret != -EEXIST)
   929				break;
   930		}
   931	
   932		if (ret)
   933			memset(sbi->syslink_name, 0, MAX_SYSLINK_NAME);
   934	
   935		return ret;
   936	}
   937	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27356 bytes --]