From: Jianyong Wu <jianyong.wu@arm.com>
To: ericvh@gmail.com, hch@lst.de, dhowells@redhat.com,
lucho@ionkov.net, asmadeus@codewreck.org
Cc: v9fs-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Kaly.Xin@arm.com,
justin.he@arm.com, jianyong.wu@arm.com, wei.chen@arm.com
Subject: [RFC PATCH 1/2] vfs: pass file down when getattr to avoid losing info.
Date: Mon, 20 Jul 2020 09:46:21 +0800 [thread overview]
Message-ID: <20200720014622.37364-2-jianyong.wu@arm.com> (raw)
In-Reply-To: <20200720014622.37364-1-jianyong.wu@arm.com>
Currently, getting attribute for a file represented by fd is always
by inode or path which may lead to bug for a certain network file system.
Adding file struct into struct kstat and assigning file for it in
vfs_statx_fd can avoid this issue. This change refers to struct istat.
Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
---
fs/stat.c | 1 +
include/linux/stat.h | 6 ++++++
2 files changed, 7 insertions(+)
diff --git a/fs/stat.c b/fs/stat.c
index 44f8ad346db4..0dee5487f6d6 100644
--- a/fs/stat.c
+++ b/fs/stat.c
@@ -147,6 +147,7 @@ int vfs_statx_fd(unsigned int fd, struct kstat *stat,
return -EINVAL;
f = fdget_raw(fd);
+ stat->filp = f.file;
if (f.file) {
error = vfs_getattr(&f.file->f_path, stat,
request_mask, query_flags);
diff --git a/include/linux/stat.h b/include/linux/stat.h
index 56614af83d4a..4755c528d49a 100644
--- a/include/linux/stat.h
+++ b/include/linux/stat.h
@@ -48,6 +48,12 @@ struct kstat {
struct timespec64 btime; /* File creation time */
u64 blocks;
u64 mnt_id;
+
+ /*
+ * Not an attribute, but an auxiliary info for filesystems wanting to
+ * implement an fstat() like method.
+ */
+ struct file *filp;
};
#endif
--
2.17.1
next prev parent reply other threads:[~2020-07-20 1:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 1:46 [RFC PATCH 0/2] vfs:9p: fix open-unlink-fstat bug Jianyong Wu
2020-07-20 1:46 ` Jianyong Wu [this message]
2020-07-20 14:53 ` [RFC PATCH 1/2] vfs: pass file down when getattr to avoid losing info Dominique Martinet
2020-07-21 10:03 ` Jianyong Wu
2020-07-20 1:46 ` [RFC PATCH 2/2] 9p: retrieve fid from file if it exists when getattr Jianyong Wu
2020-07-20 1:52 ` [RFC PATCH 0/2] vfs:9p: fix open-unlink-fstat bug Al Viro
2020-07-20 1:58 ` Jianyong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720014622.37364-2-jianyong.wu@arm.com \
--to=jianyong.wu@arm.com \
--cc=Kaly.Xin@arm.com \
--cc=asmadeus@codewreck.org \
--cc=dhowells@redhat.com \
--cc=ericvh@gmail.com \
--cc=hch@lst.de \
--cc=justin.he@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=wei.chen@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®