From: Greg KH <gregkh@linuxfoundation.org>
To: Darshan D V <darshandv10@gmail.com>
Cc: yuehaibing@huawei.com, ardb@kernel.org,
contact@christina-quast.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: rtl8192e: add space before open parenthesis
Date: Mon, 20 Jul 2020 10:22:12 +0200 [thread overview]
Message-ID: <20200720082212.GA721569@kroah.com> (raw)
In-Reply-To: <20200719120918.17862-1-darshandv10@gmail.com>
On Sun, Jul 19, 2020 at 05:39:17PM +0530, Darshan D V wrote:
> rtllib_crypt_ccmp.c:
Why is this listed here, with a trailing space? There's no real need
for it, do you see other patches for this file/driver doing that? Try
looking at those for examples of how to properly format changelog texts.
Same thing for your 2/2 patch.
thanks,
greg k-h
next prev parent reply other threads:[~2020-07-20 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 12:09 Darshan D V
2020-07-19 12:09 ` [PATCH 2/2] staging: rtl8192e: add proper code indent Darshan D V
2020-07-20 8:22 ` Greg KH [this message]
2020-07-20 9:14 [PATCH 1/2] staging: rtl8192e: add space before open parenthesis Darshan D V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720082212.GA721569@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ardb@kernel.org \
--cc=contact@christina-quast.de \
--cc=darshandv10@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome