From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C09A2C433DF for ; Mon, 20 Jul 2020 18:34:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A68ED22482 for ; Mon, 20 Jul 2020 18:34:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730849AbgGTSeu (ORCPT ); Mon, 20 Jul 2020 14:34:50 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:45570 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726546AbgGTSet (ORCPT ); Mon, 20 Jul 2020 14:34:49 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jxacc-0063zF-HV; Mon, 20 Jul 2020 20:34:42 +0200 Date: Mon, 20 Jul 2020 20:34:42 +0200 From: Andrew Lunn To: Alexander Lobakin Cc: "David S. Miller" , Jakub Kicinski , Igor Russkikh , Michal Kalderon , Ariel Elior , Denis Bolotin , "James E.J. Bottomley" , "Martin K. Petersen" , GR-everest-linux-l2@marvell.com, QLogic-Storage-Upstream@marvell.com, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 net-next 02/16] qed, qede, qedf: convert link mode from u32 to ETHTOOL_LINK_MODE Message-ID: <20200720183442.GL1339445@lunn.ch> References: <20200720180815.107-1-alobakin@marvell.com> <20200720180815.107-3-alobakin@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200720180815.107-3-alobakin@marvell.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 20, 2020 at 09:08:01PM +0300, Alexander Lobakin wrote: > Currently qed driver already ran out of 32 bits to store link modes, > and this doesn't allow to add and support more speeds. > Convert custom link mode to generic Ethtool bitmap and definitions > (convenient Phylink shorthands are used for elegance and readability). > This allowed us to drop all conversions/mappings between the driver > and Ethtool. > > This involves changes in qede and qedf as well, as they used definitions > from shared "qed_if.h". > > Suggested-by: Andrew Lunn > Signed-off-by: Alexander Lobakin > Signed-off-by: Igor Russkikh > --- > drivers/net/ethernet/qlogic/qed/qed_main.c | 288 ++++++++++-------- > .../net/ethernet/qlogic/qede/qede_ethtool.c | 200 ++++-------- > drivers/scsi/qedf/qedf_main.c | 78 +++-- > include/linux/qed/qed_if.h | 47 +-- > 4 files changed, 268 insertions(+), 345 deletions(-) Nice diffstat. Reviewed-by: Andrew Lunn Andrew