From: kernel test robot <lkp@intel.com>
To: Vaibhav Gupta <vaibhavgupta40@gmail.com>,
Bjorn Helgaas <helgaas@kernel.org>,
Vaibhav Gupta <vaibhav.varodek@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>
Cc: kbuild-all@lists.01.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v1] media: cafe-driver: use generic power management
Date: Tue, 21 Jul 2020 04:30:09 +0800 [thread overview]
Message-ID: <202007210444.LkUvoUpL%lkp@intel.com> (raw)
In-Reply-To: <20200720174545.827778-1-vaibhavgupta40@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 5268 bytes --]
Hi Vaibhav,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v5.8-rc6 next-20200720]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Vaibhav-Gupta/media-cafe-driver-use-generic-power-management/20200721-015153
base: git://linuxtv.org/media_tree.git master
config: alpha-allmodconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
drivers/media/platform/marvell-ccic/cafe-driver.c: In function 'cafe_pci_suspend':
>> drivers/media/platform/marvell-ccic/cafe-driver.c:615:2: error: implicit declaration of function 'mccic_suspend' [-Werror=implicit-function-declaration]
615 | mccic_suspend(&cam->mcam);
| ^~~~~~~~~~~~~
drivers/media/platform/marvell-ccic/cafe-driver.c: In function 'cafe_pci_resume':
>> drivers/media/platform/marvell-ccic/cafe-driver.c:626:9: error: implicit declaration of function 'mccic_resume'; did you mean 'mccic_register'? [-Werror=implicit-function-declaration]
626 | return mccic_resume(&cam->mcam);
| ^~~~~~~~~~~~
| mccic_register
cc1: some warnings being treated as errors
--
>> drivers/media/platform/marvell-ccic/mcam-core.c:1972:6: warning: no previous prototype for 'mccic_suspend' [-Wmissing-prototypes]
1972 | void mccic_suspend(struct mcam_camera *cam)
| ^~~~~~~~~~~~~
>> drivers/media/platform/marvell-ccic/mcam-core.c:1987:5: warning: no previous prototype for 'mccic_resume' [-Wmissing-prototypes]
1987 | int mccic_resume(struct mcam_camera *cam)
| ^~~~~~~~~~~~
vim +/mccic_suspend +615 drivers/media/platform/marvell-ccic/cafe-driver.c
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 605
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 606
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 607 /*
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 608 * Basic power management.
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 609 */
0ad4543b81ce3b drivers/media/platform/marvell-ccic/cafe-driver.c Vaibhav Gupta 2020-07-20 610 static int __maybe_unused cafe_pci_suspend(struct device *dev)
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 611 {
0ad4543b81ce3b drivers/media/platform/marvell-ccic/cafe-driver.c Vaibhav Gupta 2020-07-20 612 struct v4l2_device *v4l2_dev = dev_get_drvdata(dev);
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 613 struct cafe_camera *cam = to_cam(v4l2_dev);
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 614
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 @615 mccic_suspend(&cam->mcam);
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 616 return 0;
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 617 }
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 618
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 619
0ad4543b81ce3b drivers/media/platform/marvell-ccic/cafe-driver.c Vaibhav Gupta 2020-07-20 620 static int __maybe_unused cafe_pci_resume(struct device *dev)
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 621 {
0ad4543b81ce3b drivers/media/platform/marvell-ccic/cafe-driver.c Vaibhav Gupta 2020-07-20 622 struct v4l2_device *v4l2_dev = dev_get_drvdata(dev);
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 623 struct cafe_camera *cam = to_cam(v4l2_dev);
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 624
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 625 cafe_ctlr_init(&cam->mcam);
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 @626 return mccic_resume(&cam->mcam);
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 627 }
abfa3df36c01a3 drivers/media/video/marvell-ccic/cafe-driver.c Jonathan Corbet 2011-06-11 628
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 64758 bytes --]
next prev parent reply other threads:[~2020-07-20 20:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 17:45 Vaibhav Gupta
2020-07-20 20:30 ` kernel test robot [this message]
2020-07-21 4:47 ` [PATCH v2] " Vaibhav Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202007210444.LkUvoUpL%lkp@intel.com \
--to=lkp@intel.com \
--cc=corbet@lwn.net \
--cc=helgaas@kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vaibhav.varodek@gmail.com \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®