From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 632EDC433E2 for ; Tue, 21 Jul 2020 13:37:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CF41207DD for ; Tue, 21 Jul 2020 13:37:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727779AbgGUNg7 (ORCPT ); Tue, 21 Jul 2020 09:36:59 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:47180 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726412AbgGUNg7 (ORCPT ); Tue, 21 Jul 2020 09:36:59 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jxsRz-006B2n-IY; Tue, 21 Jul 2020 15:36:55 +0200 Date: Tue, 21 Jul 2020 15:36:55 +0200 From: Andrew Lunn To: Codrin Ciubotariu Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, nicolas.ferre@microchip.com, claudiu.beznea@microchip.com, davem@davemloft.net, kuba@kernel.org, f.fainelli@gmail.com, robh+dt@kernel.org, alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com Subject: Re: [PATCH net-next 3/7] net: macb: parse PHY nodes found under an MDIO node Message-ID: <20200721133655.GA1472201@lunn.ch> References: <20200721100234.1302910-1-codrin.ciubotariu@microchip.com> <20200721100234.1302910-4-codrin.ciubotariu@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200721100234.1302910-4-codrin.ciubotariu@microchip.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -755,7 +765,6 @@ static int macb_mdiobus_register(struct macb *bp) > * decrement it before returning. > */ > of_node_put(child); > - > return of_mdiobus_register(bp->mii_bus, np); > } Please avoid white space changes like this. Otherwise this looks O.K. Andrew