From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: agross@kernel.org, akashast@codeaurora.org, mka@chromium.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] soc: qcom: geni: Fix unused lable warning
Date: Tue, 21 Jul 2020 21:29:09 -0700 [thread overview]
Message-ID: <20200722042909.GJ1218486@builder.lan> (raw)
In-Reply-To: <20200722020619.25988-1-yuehaibing@huawei.com>
On Tue 21 Jul 19:06 PDT 2020, YueHaibing wrote:
> If CONFIG_SERIAL_EARLYCON is not set, gcc warns this:
>
> drivers/soc/qcom/qcom-geni-se.c: In function ‘geni_se_probe’:
> drivers/soc/qcom/qcom-geni-se.c:914:1: warning: label ‘exit’ defined but not used [-Wunused-label]
> exit:
> ^~~~
>
> Fixes: 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to fix earlycon crash")
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
and applied.
Thanks,
Bjorn
> ---
> drivers/soc/qcom/qcom-geni-se.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c
> index 3413129d73ef..d0e4f520cff8 100644
> --- a/drivers/soc/qcom/qcom-geni-se.c
> +++ b/drivers/soc/qcom/qcom-geni-se.c
> @@ -910,8 +910,8 @@ static int geni_se_probe(struct platform_device *pdev)
> if (of_get_compatible_child(pdev->dev.of_node, "qcom,geni-debug-uart"))
> earlycon_wrapper = wrapper;
> of_node_put(pdev->dev.of_node);
> -#endif
> exit:
> +#endif
> dev_set_drvdata(dev, wrapper);
> dev_dbg(dev, "GENI SE Driver probed\n");
> return devm_of_platform_populate(dev);
> --
> 2.17.1
>
>
prev parent reply other threads:[~2020-07-22 4:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 2:06 YueHaibing
2020-07-22 4:29 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722042909.GJ1218486@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®