From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98BCBC433DF for ; Wed, 22 Jul 2020 09:04:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 702D020717 for ; Wed, 22 Jul 2020 09:04:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731039AbgGVJEr (ORCPT ); Wed, 22 Jul 2020 05:04:47 -0400 Received: from mx2.suse.de ([195.135.220.15]:57108 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728360AbgGVJEr (ORCPT ); Wed, 22 Jul 2020 05:04:47 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 75BEDAF16; Wed, 22 Jul 2020 09:04:52 +0000 (UTC) Date: Wed, 22 Jul 2020 11:04:42 +0200 From: Joerg Roedel To: Erdem Aktas Cc: Peter Zijlstra , Joerg Roedel , x86@kernel.org, hpa@zytor.com, Andy Lutomirski , Dave Hansen , Jiri Slaby , Dan Williams , Tom Lendacky , Juergen Gross , Kees Cook , David Rientjes , Cfir Cohen , Masami Hiramatsu , Mike Stunes , Sean Christopherson , Martin Radev , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v4 00/75] x86: SEV-ES Guest Support Message-ID: <20200722090442.GI6132@suse.de> References: <20200714120917.11253-1-joro@8bytes.org> <20200715092456.GE10769@hirez.programming.kicks-ass.net> <20200715093426.GK16200@suse.de> <20200715095556.GI10769@hirez.programming.kicks-ass.net> <20200715101034.GM16200@suse.de> <20200721124957.GD6132@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Erdem, On Tue, Jul 21, 2020 at 09:48:51AM -0700, Erdem Aktas wrote: > Yes, I am using OVMF with SEV-ES (sev-es-v12 patches applied). I am > running Ubuntu 18.04 distro. My grub target is x86_64-efi. I also > tried installing the grub-efi-amd64 package. In all cases, the grub is > running in 64bit but enters the startup_32 in 32 bit mode. I think > there should be a 32bit #VC handler just something very similar in the > OVMF patches to handle the cpuid when the CPU is still in 32bit mode. > As it is now, it will be a huge problem to support different distro images. > I wonder if I am the only one having this problem. I havn't heard from anyone else that the startup_32 boot-path is being used for SEV-ES. What OVMF binary do you use for your guest? In general it is not that difficult to support that boot-path too, but I'd like to keep that as a future addition, as the patch-set is already quite large. In the startup_32 path there is already a GDT set up, so whats needed is an IDT and a 32-bit #VC handler using the MRS-based protocol (and hoping that there will only be CPUID intercepts until it reaches long-mode). Regards, Joerg