From: Yue Hu <zbestahu@gmail.com>
To: gregkh@linuxfoundation.org, jslaby@suse.com
Cc: linux-kernel@vger.kernel.org, huyue2@yulong.com, zbestahu@163.com
Subject: [PATCH] sysrq: use only one slot for loglevels in key table
Date: Wed, 22 Jul 2020 17:26:09 +0800 [thread overview]
Message-ID: <20200722092610.11504-1-zbestahu@gmail.com> (raw)
From: Yue Hu <huyue2@yulong.com>
Currently, sysrq_key_table[] has 10 slots for same interface to change
console loglevel. No specific purpose to do that. Let's use only one slot
to save memory space. Also, update the key2index calculation. And remove
needless code in help message print path to make the logic simpler.
Signed-off-by: Yue Hu <huyue2@yulong.com>
---
drivers/tty/sysrq.c | 27 +++++----------------------
1 file changed, 5 insertions(+), 22 deletions(-)
diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
index 7c95afa9..3f12910 100644
--- a/drivers/tty/sysrq.c
+++ b/drivers/tty/sysrq.c
@@ -442,17 +442,8 @@ static void sysrq_handle_unrt(int key)
/* Key Operations table and lock */
static DEFINE_SPINLOCK(sysrq_key_table_lock);
-static const struct sysrq_key_op *sysrq_key_table[36] = {
- &sysrq_loglevel_op, /* 0 */
- &sysrq_loglevel_op, /* 1 */
- &sysrq_loglevel_op, /* 2 */
- &sysrq_loglevel_op, /* 3 */
- &sysrq_loglevel_op, /* 4 */
- &sysrq_loglevel_op, /* 5 */
- &sysrq_loglevel_op, /* 6 */
- &sysrq_loglevel_op, /* 7 */
- &sysrq_loglevel_op, /* 8 */
- &sysrq_loglevel_op, /* 9 */
+static const struct sysrq_key_op *sysrq_key_table[27] = {
+ &sysrq_loglevel_op, /* 0 - 9 */
/*
* a: Don't use for system provided sysrqs, it is handled specially on
@@ -507,9 +498,9 @@ static int sysrq_key_table_key2index(int key)
int retval;
if ((key >= '0') && (key <= '9'))
- retval = key - '0';
+ retval = 0;
else if ((key >= 'a') && (key <= 'z'))
- retval = key + 10 - 'a';
+ retval = key + 1 - 'a';
else
retval = -1;
return retval;
@@ -577,16 +568,8 @@ void __handle_sysrq(int key, bool check_mask)
pr_info("HELP : ");
/* Only print the help msg once per handler */
for (i = 0; i < ARRAY_SIZE(sysrq_key_table); i++) {
- if (sysrq_key_table[i]) {
- int j;
-
- for (j = 0; sysrq_key_table[i] !=
- sysrq_key_table[j]; j++)
- ;
- if (j != i)
- continue;
+ if (sysrq_key_table[i])
pr_cont("%s ", sysrq_key_table[i]->help_msg);
- }
}
pr_cont("\n");
console_loglevel = orig_log_level;
--
1.9.1
next reply other threads:[~2020-07-22 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 9:26 Yue Hu [this message]
2020-07-22 10:49 ` Greg KH
2020-07-23 3:01 ` Yue Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722092610.11504-1-zbestahu@gmail.com \
--to=zbestahu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=huyue2@yulong.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zbestahu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®