From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 476ACC433E2 for ; Wed, 22 Jul 2020 13:03:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E9A220729 for ; Wed, 22 Jul 2020 13:03:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732382AbgGVNDL (ORCPT ); Wed, 22 Jul 2020 09:03:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726146AbgGVNDK (ORCPT ); Wed, 22 Jul 2020 09:03:10 -0400 Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32DFDC0619DC for ; Wed, 22 Jul 2020 06:03:10 -0700 (PDT) Received: by theia.8bytes.org (Postfix, from userid 1000) id D81502C8; Wed, 22 Jul 2020 15:03:08 +0200 (CEST) Date: Wed, 22 Jul 2020 15:03:07 +0200 From: Joerg Roedel To: Colin King Cc: Tony Lindgren , Hiroshi DOYU , iommu@lists.linux-foundation.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] OMAP: iommu: check for failure of a call to omap_iommu_dump_ctx Message-ID: <20200722130307.GC27672@8bytes.org> References: <20200714192211.744776-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200714192211.744776-1-colin.king@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 14, 2020 at 08:22:11PM +0100, Colin King wrote: > From: Colin Ian King > > It is possible for the call to omap_iommu_dump_ctx to return > a negative error number, so check for the failure and return > the error number rather than pass the negative value to > simple_read_from_buffer. > > Addresses-Coverity: ("Improper use of negative value") > Fixes: 14e0e6796a0d ("OMAP: iommu: add initial debugfs support") > Signed-off-by: Colin Ian King > --- > drivers/iommu/omap-iommu-debug.c | 3 +++ > 1 file changed, 3 insertions(+) Applied, thanks.